Skip to content
This repository was archived by the owner on Jan 9, 2023. It is now read-only.
This repository was archived by the owner on Jan 9, 2023. It is now read-only.

RPM install should stop/rollback if any error occurs in a scriptlet #743

Open
@tst-ccamp

Description

@tst-ccamp

This is a follow-up to #720 because this task proved to be larger in scope than anticipated. The end goal is to leave the set -e flag in for all the scriptlets, but cleanup in error handling is needed throughout.

AC

  1. RPM installs will halt the installation if any errors occur during RPM scripets (all RPMs)
  2. write follow-up tickets if errors reporting lacking specificity (either in RPM command output or ansible)

Scenarios to consider

  1. With/without MrSID library installed when RPMs are compiled against MrSID
  2. Install on a "clean" server (Has never had GEE installed before)
  3. Upgrading an existing RPM

NOTES

  1. ensure scriptlets have set -e; review code for explicit set +e (don't want that one)
  2. handle better individual scriptlets command and potential errors
  3. use OR command to ignore errors that are known and OK to fail for specific commands
  4. errors that occur in a post-install script do not roll back the RPM install, so good error messages are important to let the installer know what should be done to fix the issue
    • Consider allowing the script to continue with other required steps if possible

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions