Remove definitions of synchronous CreateSubscription API

PiperOrigin-RevId: 615186290

Author: rahkr

ecclesia/lib/redfish/event/server/subscription.h

@@ -270,11 +270,6 @@ class SubscriptionBackend {
   virtual absl::Status Query(absl::string_view url,
                              QueryCallback query_callback) = 0;
 
-  // Subscribes to Redfish events for the given URL and returns the list of
-  // event source IDs
-  virtual absl::StatusOr<std::vector<EventSourceId>> Subscribe(
-      absl::string_view url) = 0;
-
   // Subscribes to Redfish events for the given URL and invokes the callback
   // post subscription.
   virtual absl::Status Subscribe(absl::string_view url,
@@ -290,10 +285,6 @@ class SubscriptionService {
   // created subscription.
   // Note: the implementation must guarantee that `on_event_callback` will only
   // be called once at a time. No parallel call will be allowed!
-  virtual absl::StatusOr<SubscriptionId> CreateSubscription(
-      const nlohmann::json &request,
-      std::function<void(const nlohmann::json &)> &&on_event_callback) = 0;
-
   virtual void CreateSubscription(
       const nlohmann::json &request,
       std::function<void(const absl::StatusOr<SubscriptionId> &)>

ecclesia/lib/redfish/event/server/subscription_impl.cc

@@ -331,14 +331,6 @@ class SubscriptionServiceImpl
     }
   }
 
-  ABSL_DEPRECATED("Use asynchrounous version of CreateSubscription instead.")
-  absl::StatusOr<SubscriptionId> CreateSubscription(
-      const nlohmann::json &request,
-      std::function<void(const nlohmann::json &)> &&on_event_callback)
-      override {
-    return absl::UnimplementedError("CreateSubscription:: Deprecated!");
-  }
-
   void DeleteSubscription(const SubscriptionId& subscription_id) override {
     subscription_store_->DeleteSubscription(subscription_id);
   }

ecclesia/lib/redfish/event/server/subscription_mock.h

@@ -52,8 +52,6 @@ class SubscriptionStoreMock : public SubscriptionStore {
 
 class SubscriptionBackendMock : public SubscriptionBackend {
  public:
-  MOCK_METHOD(absl::StatusOr<std::vector<EventSourceId>>, Subscribe,
-              (absl::string_view url), (override));
   MOCK_METHOD(absl::Status, Subscribe,
               (absl::string_view url, SubscribeCallback subscribe_callback),
               (override));
@@ -72,11 +70,6 @@ class EventStoreMock : public EventStore {
 
 class SubscriptionServiceMock : public SubscriptionService {
  public:
-  MOCK_METHOD(absl::StatusOr<SubscriptionId>, CreateSubscription,
-              (const nlohmann::json &request,
-               std::function<void(const nlohmann::json &)> &&on_event_callback),
-              (override));
-
   MOCK_METHOD(void, CreateSubscription,
               (const nlohmann::json &request,
                std::function<void(const absl::StatusOr<SubscriptionId> &)>