Multiple top level records: also evil.

PiperOrigin-RevId: 762147462

Author: graememorgan

core/src/main/java/com/google/errorprone/bugpatterns/MultipleTopLevelClasses.java

@@ -49,24 +49,17 @@ public Description matchCompilationUnit(CompilationUnitTree tree, VisitorState s
     List<String> names = new ArrayList<>();
     for (Tree member : tree.getTypeDecls()) {
       if (member instanceof ClassTree classMember) {
-        switch (classMember.getKind()) {
-          case CLASS, INTERFACE, ANNOTATION_TYPE, ENUM -> {
-            if (isSuppressed(classMember, state)) {
-              // If any top-level classes have @SuppressWarnings("TopLevel"), ignore
-              // this compilation unit. We can't rely on the normal suppression
-              // mechanism because the only enclosing element is the package declaration,
-              // and @SuppressWarnings can't be applied to packages.
-              return NO_MATCH;
-            }
-            names.add(classMember.getSimpleName().toString());
-          }
-          default -> {}
+        if (isSuppressed(classMember, state)) {
+          // If any top-level classes have @SuppressWarnings("TopLevel"), ignore
+          // this compilation unit. We can't rely on the normal suppression
+          // mechanism because the only enclosing element is the package declaration,
+          // and @SuppressWarnings can't be applied to packages.
+          return NO_MATCH;
         }
+        names.add(classMember.getSimpleName().toString());
       }
     }
     if (names.size() <= 1) {
-      // this can happen with multiple type declarations if some of them are
-      // empty (e.g. ";" at the top level counts as an empty type decl)
       return NO_MATCH;
     }
     String message =

core/src/test/java/com/google/errorprone/bugpatterns/MultipleTopLevelClassesTest.java

@@ -124,4 +124,21 @@ public void semiInImportList() {
             "class Extra {}")
         .doTest();
   }
+
+  @Test
+  public void twoRecords() {
+    compilationHelper
+        .addSourceLines(
+            "a/A.java",
+            """
+            package a;
+
+            // BUG: Diagnostic contains: one top-level class declaration, instead found: One, Two
+            record One() {}
+
+            // BUG: Diagnostic contains:
+            record Two() {}
+            """)
+        .doTest();
+  }
 }