Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing seperator in static fold in #2159

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix missing seperator in static fold in #2159

wants to merge 2 commits into from

Conversation

jheek
Copy link
Member

@jheek jheek commented May 27, 2022

fixes #2157

@jheek jheek requested a review from levskaya May 27, 2022 09:54
levskaya
levskaya approved these changes Jun 1, 2022
View reviewed changes
Copy link
Collaborator

@levskaya levskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Seeing a number of internal tests fail due to RNG change... will have to think about how to deal with that.

levskaya
levskaya approved these changes Jun 1, 2022
View reviewed changes
Copy link
Collaborator

@levskaya levskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loooks good. I'm seeing this break a bunch of internal tests due to overtight tolerances, golden tests, etc... so we'll need to decide how to integrate it.

@marcvanzee marcvanzee added the Priority: P1 - soon Response within 5 business days. Resolution within 30 days. (Assignee required) label Jun 9, 2022
@marcvanzee
Copy link
Collaborator

@levskaya any update on this?

@chiamp chiamp mentioned this pull request May 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levskaya levskaya levskaya approved these changes

Assignees

@jheek jheek

Labels
Priority: P1 - soon Response within 5 business days. Resolution within 30 days. (Assignee required) pull ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LazyRNG can accidentally have key sharing across layers.
3 participants
@jheek @marcvanzee @levskaya