RecyclerView crashing in some circumstances

[donpwilson]

I have been experimenting with "com.google.android:flexbox:0.3.0-alpha2" with a view to adding it to my photo app as an alternative way of displaying photos. I appreciate that this version is not yet fully stable.

I experience a crash in certain circumstances and report it here in the hope that your testing / debugging can resolve it.

I display a grid of photos and have buttons that enable the user to zoom in or out of the grid. These vary to height of each row. I get a crash on zoom in when the bottom photos are pushed out of view. I'm thinking that there is a confusion between being detached and being recycled. This crash also follows a warning message from View's requestLayout(). Here's the log:

03-29 11:47:42.833 21953-21953/com.dpw.photoplayer W/View: requestLayout() improperly called by android.support.v7.widget.AppCompatTextView{3c009ebc V.ED..C. ......ID 6,306-359,363 #7f100199 app:id/photo_text} during layout: running second layout pass
03-29 11:47:42.833 21953-21953/com.dpw.photoplayer W/View: requestLayout() improperly called by android.support.v7.widget.AppCompatTextView{3e090e45 V.ED.... ......ID 170,6-194,63 #7f100197 app:id/photo_count} during layout: running second layout pass
03-29 11:47:42.833 21953-21953/com.dpw.photoplayer W/View: requestLayout() improperly called by android.support.v7.widget.AppCompatImageView{3a92499a V.ED.... ......ID 6,6-552,366 #7f100193 app:id/photo_image} during layout: running second layout pass
03-29 11:47:42.833 21953-21953/com.dpw.photoplayer W/View: requestLayout() improperly called by android.support.v7.widget.AppCompatTextView{9d272cb V.ED..C. ......ID 110,306-448,363 #7f100199 app:id/photo_text} during layout: running second layout pass
03-29 11:47:42.833 21953-21953/com.dpw.photoplayer W/View: requestLayout() improperly called by android.support.v7.widget.AppCompatTextView{2196eaa8 V.ED.... ......ID 267,6-291,63 #7f100197 app:id/photo_count} during layout: running second layout pass
03-29 11:47:42.979 21953-21953/com.dpw.photoplayer E/AndroidRuntime: FATAL EXCEPTION: main
                                                                     Process: com.dpw.photoplayer, PID: 21953
                                                                     java.lang.IllegalArgumentException: Tmp detached view should be removed from RecyclerView before it can be recycled: ViewHolder{11587ca3 position=3 id=-776809114, oldPos=-1, pLpos:-1 tmpDetached no parent}
                                                                         at android.support.v7.widget.RecyclerView$Recycler.recycleViewHolderInternal(RecyclerView.java:5692)
                                                                         at android.support.v7.widget.RecyclerView.removeAnimatingView(RecyclerView.java:1279)
                                                                         at android.support.v7.widget.RecyclerView$ItemAnimatorRestoreListener.onAnimationFinished(RecyclerView.java:11518)
                                                                         at android.support.v7.widget.RecyclerView$ItemAnimator.dispatchAnimationFinished(RecyclerView.java:12018)
                                                                         at android.support.v7.widget.SimpleItemAnimator.dispatchRemoveFinished(SimpleItemAnimator.java:265)
                                                                         at android.support.v7.widget.DefaultItemAnimator$4.onAnimationEnd(DefaultItemAnimator.java:209)
                                                                         at android.support.v4.view.ViewPropertyAnimatorCompatJB$1.onAnimationEnd(ViewPropertyAnimatorCompatJB.java:51)
                                                                         at android.view.ViewPropertyAnimator$AnimatorEventListener.onAnimationEnd(ViewPropertyAnimator.java:1116)
                                                                         at android.animation.ValueAnimator.endAnimation(ValueAnimator.java:1171)
                                                                         at android.animation.ValueAnimator$AnimationHandler.doAnimationFrame(ValueAnimator.java:722)
                                                                         at android.animation.ValueAnimator$AnimationHandler.run(ValueAnimator.java:738)
                                                                         at android.view.Choreographer$CallbackRecord.run(Choreographer.java:767)
                                                                         at android.view.Choreographer.doCallbacks(Choreographer.java:580)
                                                                         at android.view.Choreographer.doFrame(Choreographer.java:549)
                                                                         at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:753)
                                                                         at android.os.Handler.handleCallback(Handler.java:739)
                                                                         at android.os.Handler.dispatchMessage(Handler.java:95)
                                                                         at android.os.Looper.loop(Looper.java:135)
                                                                         at android.app.ActivityThread.main(ActivityThread.java:5254)
                                                                         at java.lang.reflect.Method.invoke(Native Method)
                                                                         at java.lang.reflect.Method.invoke(Method.java:372)
                                                                         at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903)
                                                                         at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)
`

[thagikura]

Thanks for reporting!

Is it possible to share your piece of code that may be relevant to reproduce it?

[donpwilson]

Here's what I hope is the most relevant code. My adapter is full of what I think is irrelevant code so I have cut it down below to what I think is relevant. I've also cut down the photo_item layout substantially. You will see that I set the size of each photo in the imageView so that its height matches the grid side and its width respects its aspect ratio. I should perhaps add that I don't have any issues with the other layout managers. I hope this helps:

Code to initialize:

   private void setGridLayoutManager() {
        int type = My_Preferences.getInstance().getGridLayout();
        switch (type) {
            case 0:
                pGridLayoutManager = new StaggeredGridLayoutManager(2, GridLayoutManager.VERTICAL);
                pCurrentLayoutManagerType = GRID_TYPE.STAGGERED_GRID;
                break;
            case 1:
                pGridLayoutManager = new GridLayoutManager(getActivity(), 2, GridLayoutManager.VERTICAL, false);
                pCurrentLayoutManagerType = VERTICAL_LINEAR_GRID;
                break;
            case 2:
                pGridLayoutManager = new GridLayoutManager(getActivity(), 2, GridLayoutManager.VERTICAL, false);
                pCurrentLayoutManagerType = VERTICAL_GRID_OF_SQUARES;
                break;
            case 3:
                FlexboxLayoutManager layoutManager = new FlexboxLayoutManager();
                layoutManager.setFlexWrap(FlexWrap.WRAP);
                layoutManager.setFlexDirection(FlexDirection.ROW);
                layoutManager.setAlignItems(AlignItems.STRETCH);
                layoutManager.setJustifyContent(JustifyContent.CENTER);
                pGridLayoutManager = layoutManager;
                pCurrentLayoutManagerType = VERTICAL_FILLED_ROWS;
                break;
            default:
                pGridLayoutManager = new GridLayoutManager(getActivity(), 2, GridLayoutManager.VERTICAL, false);
                pCurrentLayoutManagerType = VERTICAL_LINEAR_GRID;
                break;
        }
        pGridGallery.setLayoutManager(pGridLayoutManager);
    }

Code to reset grid side:

pAdapter.setGridSide(grid_side);

Cut down adapter:

class Adapter_Photo_Album_Copy extends RecyclerView.Adapter<Adapter_Photo_Album_Copy.ViewHolder> {

    private Fragment_Photo_Album.GRID_TYPE pLayoutType;
    private int pGridSide;

    @Override
    public int getItemCount() {
        return ....
    }

    Photo_Record getItem(final int position) {
        Photo_Record record = null;
        return....
    }

    void setGridSide(final int side) {
        if (side != pGridSide) {
            pGridSide = side;
            if (getItemCount() > 0) {
                runOnUiThread(new Runnable() {
                    @Override
                    public void run() {
                        notifyItemRangeChanged(0, getItemCount());
                    }
                });
            }
        }
    }

    @Override
    public ViewHolder onCreateViewHolder(ViewGroup viewGroup, int viewType) {
        View v = LayoutInflater.from(viewGroup.getContext())
                .inflate(R.layout.photo_item, viewGroup, false);
        return new ViewHolder(v);
    }

    @Override
    public void onBindViewHolder(final ViewHolder viewHolder, final int position) {
        if (position != RecyclerView.NO_POSITION) {
            final Photo_Record photo_record = getItem(position);
            if (photo_record != null) {
                final Source_Record source_record = photo_record.getSourceRecord();
                if (source_record != null) {
                    final String photo = photo_record.getPhoto();
                    Point dimensions = photo_record.getDimensionsAdjustedForOrientation();
                    int grid_item_height;
                    int grid_item_width;
                    FrameLayout.LayoutParams params = (FrameLayout.LayoutParams) viewHolder.getImageView().getLayoutParams();
                    if (pLayoutType == Fragment_Photo_Album.GRID_TYPE.HORIZONTAL_SINGLE_ROW) {
                        //....
                    } else if (pLayoutType == Fragment_Photo_Album.GRID_TYPE.VERTICAL_FILLED_ROWS) {
                        grid_item_height = pGridSide;
                        // adjusts for borders
                        grid_item_width = (int) ((double) (grid_item_height - My_Utils.dpToPx(2)) * (double) dimensions.x /
                                (double) dimensions.y) + My_Utils.dpToPx(2);
                    } else {
                        //....
                    }
                    params.width = grid_item_width;
                    params.height = grid_item_height;
                    viewHolder.getImageView().setLayoutParams(params);
                    if (pLayoutType == Fragment_Photo_Album.GRID_TYPE.VERTICAL_GRID_OF_SQUARES) {
                        viewHolder.getImageView().setScaleType(ImageView.ScaleType.CENTER_CROP);
                    } else {
                        viewHolder.getImageView().setScaleType(ImageView.ScaleType.FIT_CENTER);
                    }
                    if ((grid_item_width > My_Utils.dpToPx(2)) && (grid_item_height > My_Utils.dpToPx(2))) {
                        //......
                    }
                }
            }
        }
    }

    class ViewHolder extends RecyclerView.ViewHolder {
        private final LinearLayout layout;
        private final ImageView imageView;

        ViewHolder(View v) {
            super(v);
            layout = (LinearLayout) v.findViewById(R.id.photo_item);
            imageView = (ImageView) v.findViewById(R.id.photo_image);
        }

        LinearLayout getLayoutView() {
            return layout;
        }

        ImageView getImageView() {
            return imageView;
        }
    }
}

Layout:

<LinearLayout
    android:id="@+id/photo_item"
    xmlns:android="http://schemas.android.com/apk/res/android"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:layout_gravity="center"
    android:gravity="center"
    android:orientation="horizontal">

    <FrameLayout
        android:id="@+id/photo_border"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:background="@drawable/photo_background">

        <ImageView
            android:id="@+id/photo_image"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            android:layout_gravity="center"
            android:adjustViewBounds="true"
            android:contentDescription="@string/app_name"
            android:gravity="center"
            android:scaleType="fitCenter"/>

  </FrameLayout>

</LinearLayout>

[thagikura]

Thanks for pasting the code.

How do you zoom in the RecyclerView when the button is clicked?

[donpwilson]

I just calculate a new value and feed it to the adapter through setGridSide(). As you can see above this runs notifyItemRangeChanged() on all the items in the adapter. onBindViewHolder() then picks up the revised height and recalculates the size of each photo.

[thagikura]

Sorry for the delayed reply.

I couldn't still figure out the root cause of this issue.
By any chance is it possible to create a sample project that I can build and debug?

Also there is a new version of 0.3.0-alpha3 with bunch of bug fixes.
So it doesn't hurt if you can try it and see if it's fixed.

Thanks.

[donpwilson]

I've already tried 0.3.0-alpha3 and the problem still exists.

It might take me a little while but I'll try to set something up, maybe using your cats sample app as a base.

[thagikura]

Thanks. Really appreciate it.

[donpwilson]

I've set up zoom in / out on the cats sample ad it worked fine. So I looked harder at the crash. I noticed that it appears to be to do with the animation of views, specifically as they are removed from view. I switched off this animation in my app and it no longer crashes. However it then does not properly refresh until I scroll up or down.

I tried to clear animations on view detach from window but with no effect. See http://stackoverflow.com/questions/26724964/how-to-animate-recyclerview-items-when-they-appear

Does this help at all?

[thagikura]

Thanks! It's very helpful.
Is it possible to see your forked version of the cat demo app?
I'd like to try and see the code 👍

[donpwilson]

How best can I send you the code. Email the zipped file? Or, I've never used gist but you could start me off?

[thagikura]

Sure, either of creating a GitHub repository, or attaching a zipped file to this issue are convenient to see the file.
Thanks in advance :)

[donpwilson]

Here's a zipped file. You will find that I haven't changed very much. Feel free to incorporate in an enhanced demo if you wish.
demo-cat-gallery.zip

[thagikura]

Thank you! I was able to launch the app, but what operations are needed to reproduce?
I tried several operations including "zoom in" and "zoom out" including pushing the bottom image out of the boundary by tapping "zoom in", but couldn't reproduce it so far.

[donpwilson]

Sorry about the confusion. The cat app doesn't crash. When I said that I looked further at the crash I meant the crash in my app - I included the logcat at the top of this correspondence where you can see how it appears to be related to the animation of views.