@@ -40,7 +40,7 @@ keep the code consistent and avoid common pitfalls.
40
40
41
41
You must complete the
42
42
[ Contributor License Agreement] ( https://cla.developers.google.com/clas ) . You can
43
- do this online, and it only takes a minute. If you've never submitted code
43
+ do this online, and it takes only a minute. If you've never submitted code
44
44
before, you must add your (or your organization's) name and contact info to the
45
45
[ AUTHORS] ( AUTHORS ) file.
46
46
@@ -58,13 +58,12 @@ To send us a pull request:
58
58
go to ` https://github.com/google/flutter.widgets ` and click the
59
59
"Compare & pull request" button
60
60
61
- Please make sure all your checkins have detailed commit messages explaining the patch.
61
+ Please make sure all your checkins have detailed commit messages explaining
62
+ what the patch does and * why* . ** Changes to code behavior should include unit
63
+ tests** that would fail without the change.
62
64
63
65
Once you've gotten an LGTM from a project maintainer and once your PR has
64
66
received the green light from all our automated testing (Travis, Appveyor, etc),
65
- one of the project maintainers will merge the changes to our internal repo. This
67
+ one of the project maintainers will test the changes to our internal repo. This
66
68
might cause test failures that need to be debugged internally so we might make
67
69
further suggestions on your PR.
68
-
69
- Once the internal change is submitted to the private repo, we will run our sync
70
- scripts to bring this repo up to date. At that point, your PR will be closed.
0 commit comments