Skip to content

Commit df7f6bd

Browse files
committed
Adjust CONTRIBUTING.md to mention tests
Also make scrollable_positioned_list_example non-publishable.
1 parent 48cd258 commit df7f6bd

File tree

3 files changed

+8
-7
lines changed

3 files changed

+8
-7
lines changed

AUTHORS

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Below is a list of people and organizations that have contributed
2-
# to the Flutter project. Names should be added to the list like so:
2+
# to the Flutter Widgets project. Names should be added to the list like so:
33
#
44
# Name/Organization <email address>
55

CONTRIBUTING.md

+5-6
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ keep the code consistent and avoid common pitfalls.
4040

4141
You must complete the
4242
[Contributor License Agreement](https://cla.developers.google.com/clas). You can
43-
do this online, and it only takes a minute. If you've never submitted code
43+
do this online, and it takes only a minute. If you've never submitted code
4444
before, you must add your (or your organization's) name and contact info to the
4545
[AUTHORS](AUTHORS) file.
4646

@@ -58,13 +58,12 @@ To send us a pull request:
5858
go to `https://github.com/google/flutter.widgets` and click the
5959
"Compare & pull request" button
6060

61-
Please make sure all your checkins have detailed commit messages explaining the patch.
61+
Please make sure all your checkins have detailed commit messages explaining
62+
what the patch does and *why*. **Changes to code behavior should include unit
63+
tests** that would fail without the change.
6264

6365
Once you've gotten an LGTM from a project maintainer and once your PR has
6466
received the green light from all our automated testing (Travis, Appveyor, etc),
65-
one of the project maintainers will merge the changes to our internal repo. This
67+
one of the project maintainers will test the changes to our internal repo. This
6668
might cause test failures that need to be debugged internally so we might make
6769
further suggestions on your PR.
68-
69-
Once the internal change is submitted to the private repo, we will run our sync
70-
scripts to bring this repo up to date. At that point, your PR will be closed.

packages/scrollable_positioned_list/example/pubspec.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
name: scrollable_positioned_list_example
22

3+
publish_to: 'none'
4+
35
environment:
46
sdk: '>=2.12.0-0 <3.0.0'
57
flutter: '>=1.13.8'

0 commit comments

Comments
 (0)