Skip to content

Commit 14e705f

Browse files
[io] fix: switch to uuid4 to generation names for SheetWriter output
1 parent 5959186 commit 14e705f

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

libs/io/garf_io/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,4 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
__version__ = '0.0.10'
15+
__version__ = '0.0.11'

libs/io/garf_io/writers/sheets_writer.py

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@
2424
'Please install garf-io with sheets support - `pip install garf-io[sheets]`'
2525
) from e
2626

27-
import datetime
2827
import functools
2928
import logging
3029
import pathlib
30+
import uuid
3131

3232
from garf_core import report as garf_report
3333
from typing_extensions import override
@@ -70,11 +70,11 @@ def __init__(
7070
def write(
7171
self,
7272
report: garf_report.GarfReport,
73-
destination: str = f'Report {datetime.datetime.now(datetime.UTC)}',
73+
destination: str = f'Report {uuid.uuid4().hex}',
7474
) -> str:
7575
report = self.format_for_write(report)
7676
if not destination:
77-
destination = f'Report {datetime.datetime.now(datetime.UTC)}'
77+
destination = f'Report {uuid.uuid4().hex}'
7878
destination = formatter.format_extension(destination)
7979
num_data_rows = len(report) + 1
8080
try:
@@ -106,7 +106,7 @@ def client(self) -> gspread.Client:
106106
if (credentials_file := config_dir / 'credentials.json').is_file():
107107
return gspread.oauth(credentials_filename=credentials_file)
108108
if (credentials_file := config_dir / 'service_account.json').is_file():
109-
return self._init_service_account(credential_file)
109+
return self._init_service_account(credentials_file)
110110
raise SheetWriterError(
111111
'Failed to find either service_accounts.json or '
112112
'credentials.json files.'
@@ -133,9 +133,7 @@ def spreadsheet(self) -> gspread.spreadsheet.Spreadsheet:
133133
if self._spreadsheet:
134134
return self._spreadsheet
135135
if not self.spreadsheet_url:
136-
spreadsheet = self.client.create(
137-
title=f'Garf CSV {datetime.datetime.now(datetime.UTC)}'
138-
)
136+
spreadsheet = self.client.create(title=f'Garf CSV {uuid.uuid4().hex}')
139137
self.spreadsheet_url = spreadsheet.url
140138
return spreadsheet
141139
return self.client.open_by_url(self.spreadsheet_url)

0 commit comments

Comments
 (0)