Skip to content

Commit 3dd0ef7

Browse files
[core]: feat: fields from virtual column are added to fields property
1 parent 75ded52 commit 3dd0ef7

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

libs/core/garf_core/query_editor.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -519,6 +519,10 @@ def extract_virtual_columns(self) -> Self:
519519
line_elements = ExtractedLineElements.from_query_line(line)
520520
if virtual_column := line_elements.virtual_column:
521521
self.query.virtual_columns[line_elements.alias] = virtual_column
522+
if fields := virtual_column.fields:
523+
for field in fields:
524+
if field not in self.query.fields:
525+
self.query.fields.append(field)
522526
return self
523527

524528
def extract_customizers(self) -> Self:

libs/core/tests/unit/test_query_editor.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,10 @@ def test_generate_returns_correct(self, query):
6363
'campaign.id',
6464
'ad_group.id',
6565
'ad_group_ad.ad.id',
66-
# 'metrics.cost_micros',
67-
# 'metrics.clicks',
68-
# 'metrics.impressions',
66+
'metrics.clicks',
67+
'metrics.impressions',
68+
'metrics.cost_micros',
69+
'video.video_id',
6970
],
7071
column_names=[
7172
'constant',

0 commit comments

Comments
 (0)