Skip to content

Commit 64af07b

Browse files
[dbm] fix: stop API response processing on half-empty lines
When line with empty element appear it means that we're working on a summary line.
1 parent fd0d780 commit 64af07b

File tree

3 files changed

+14
-2
lines changed

3 files changed

+14
-2
lines changed
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
SELECT
2+
date AS date,
3+
youtube_ad_video_id AS media_url,
4+
youtube_ad_video AS media_name,
5+
metric_impressions AS impressions,
6+
metric_clicks AS clicks
7+
FROM youtube
8+
WHERE advertiser = {advertiser_id}
9+
AND dataRange = LAST_30_DAYS

libs/community/google/bid-manager/garf_bid_manager/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
'BidManagerApiReportFetcher',
2222
]
2323

24-
__version__ = '0.0.1'
24+
__version__ = '0.0.2'
2525

2626
logging.getLogger('googleapiclient.discovery_cache').setLevel(logging.ERROR)
2727
logging.getLogger('google_auth_oauthlib.flow').setLevel(logging.ERROR)

libs/community/google/bid-manager/garf_bid_manager/api_clients.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,10 @@ def get_response(
113113
results = []
114114
for row in data[1:]:
115115
if row := row.strip():
116-
result = dict(zip(request.fields, row.split(',')))
116+
elements = row.split(',')
117+
if not elements[0]:
118+
break
119+
result = dict(zip(request.fields, elements))
117120
results.append(result)
118121
else:
119122
break

0 commit comments

Comments
 (0)