Skip to content

Commit e6d073e

Browse files
[executors] fix: add __init__.py to entrypoints and refine logging
1 parent 27bae2d commit e6d073e

File tree

4 files changed

+16
-12
lines changed

4 files changed

+16
-12
lines changed

libs/exporters/garf_exporter/entrypoints/__init__.py

Whitespace-only changes.

libs/exporters/garf_exporter/entrypoints/cli.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,12 @@
2626
import datetime
2727

2828
import fastapi
29-
import garf_exporter
3029
import prometheus_client
3130
import requests
3231
import uvicorn
3332
from garf_executors.entrypoints import utils as garf_utils
33+
34+
import garf_exporter
3435
from garf_exporter import exporter_service
3536

3637

@@ -80,12 +81,6 @@ def healthcheck(host: str, port: int) -> bool:
8081
metrics_app = prometheus_client.make_asgi_app(registry=exporter.registry)
8182
app.mount('/metrics', metrics_app)
8283

83-
logger = garf_utils.init_logging(
84-
loglevel='INFO',
85-
logger_type='rich',
86-
name='garf-exporter',
87-
)
88-
8984

9085
async def start_metric_generation(
9186
request: exporter_service.GarfExporterRequest,
@@ -153,6 +148,11 @@ def main() -> None: # noqa: D103
153148
parser.add_argument('--collectors', dest='collectors', default='default')
154149
parser.add_argument('-v', '--version', dest='version', action='store_true')
155150
args, kwargs = parser.parse_known_args()
151+
garf_utils.init_logging(
152+
loglevel=args.loglevel,
153+
logger_type=args.logger,
154+
name='garf-exporter',
155+
)
156156
cli_parameters = garf_utils.ParamsParser(['macro', 'source']).parse(kwargs)
157157
runtime_options = exporter_service.GarfExporterRuntimeOptions(
158158
expose_type=args.expose_type,

libs/exporters/garf_exporter/exporter.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@
2626
import garf_core
2727
import prometheus_client
2828

29+
logger = logging.getLogger(__name__)
30+
2931

3032
class GarfExporter:
3133
"""Exposes reports from Ads API in Prometheus format.
@@ -181,7 +183,7 @@ def _define_metrics(
181183
if virtual_columns := query_specification.virtual_columns:
182184
for column, field in virtual_columns.items():
183185
metrics[column] = self._define_gauge(column, suffix, labels, namespace)
184-
logging.debug('metrics: %s', metrics)
186+
logger.debug('metrics: %s', metrics)
185187
return metrics
186188

187189
def _define_labels(
@@ -205,7 +207,7 @@ def _define_labels(
205207
for column, field in zip(non_virtual_columns, query_specification.fields):
206208
if 'metric' not in field and 'metric' not in column:
207209
labelnames.append(str(column))
208-
logging.debug('labelnames: %s', labelnames)
210+
logger.debug('labelnames: %s', labelnames)
209211
return labelnames
210212

211213
def _define_gauge(

libs/exporters/garf_exporter/exporter_service.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@
3030
import garf_exporter
3131
from garf_exporter import collector
3232

33+
logger = logging.getLogger(__name__)
34+
3335

3436
class GarfExporterRuntimeOptions(pydantic.BaseModel):
3537
"""Options to finetune exporting process.
@@ -121,14 +123,14 @@ def generate_metrics(
121123
request: Complete request to fetch and expose data.
122124
exporter: Initialized GarfExporter.
123125
"""
124-
logging.info('Beginning export')
126+
logger.info('Beginning export')
125127
start_export_time = time()
126128
exporter.export_started.set(start_export_time)
127129
collectors = request.collectors or collector.load_collector_data(
128130
request.collectors_config
129131
)
130132
for col in collectors:
131-
logging.info('Exporting from collector: %s', col.title)
133+
logger.info('Exporting from collector: %s', col.title)
132134
start = time()
133135
report = self.fetcher.fetch(col.query, **self.source_parameters)
134136
end = time()
@@ -138,7 +140,7 @@ def generate_metrics(
138140
suffix=col.suffix,
139141
collector=col.title,
140142
)
141-
logging.info('Export completed')
143+
logger.info('Export completed')
142144
end_export_time = time()
143145
exporter.export_completed.set(end_export_time)
144146
exporter.total_export_time_gauge.set(end_export_time - start_export_time)

0 commit comments

Comments
 (0)