Skip to content

ggcr: github.com/docker/docker v28.0.1 breaks interface #2072

Open
@imjasonh

Description

@imjasonh

Using v28.0.1 we can't build pkg/v1/daemon:

Error: ../../../go/pkg/mod/github.com/google/[email protected]/pkg/v1/daemon/options.go:40:9: cannot use client.NewClientWithOpts(client.FromEnv) (value of type *client.Client) as Client value in return statement: *client.Client does not implement Client (wrong type for method ImageHistory)
		have ImageHistory(context.Context, string, ...client.ImageHistoryOption) ([]image.HistoryResponseItem, error)
		want ImageHistory(context.Context, string) ([]image.HistoryResponseItem, error)

To fix this for now, you can pin this in your go.mod

	github.com/docker/docker v27.5.1+incompatible

This won't work forever. Updating the interface to accept v28's signature will break folks that use it with < v28 :-/

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions