Skip to content

Commit 938b9de

Browse files
authored
[launcher] Update cs host directory permission (#571)
Non root workload should be able to access the directory. 0744 doesn't include the execute permission for non root user. Change it to 0755
1 parent eea5eb2 commit 938b9de

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

launcher/container_runner.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -476,7 +476,7 @@ func (r *ContainerRunner) fetchAndWriteToken(ctx context.Context) error {
476476
// retry specifies the refresher goroutine's retry policy.
477477
func (r *ContainerRunner) fetchAndWriteTokenWithRetry(ctx context.Context,
478478
retry func() *backoff.ExponentialBackOff) error {
479-
if err := os.MkdirAll(launcherfile.HostTmpPath, 0744); err != nil {
479+
if err := os.MkdirAll(launcherfile.HostTmpPath, 0755); err != nil {
480480
return err
481481
}
482482
duration, err := r.refreshToken(ctx)

launcher/container_runner_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ func TestRefreshToken(t *testing.T) {
160160
logger: logging.SimpleLogger(),
161161
}
162162

163-
if err := os.MkdirAll(launcherfile.HostTmpPath, 0744); err != nil {
163+
if err := os.MkdirAll(launcherfile.HostTmpPath, 0755); err != nil {
164164
t.Fatalf("Error creating host token path directory: %v", err)
165165
}
166166

@@ -205,7 +205,7 @@ func TestRefreshTokenWithSignedContainerCacheEnabled(t *testing.T) {
205205
logger: logging.SimpleLogger(),
206206
}
207207

208-
if err := os.MkdirAll(launcherfile.HostTmpPath, 0744); err != nil {
208+
if err := os.MkdirAll(launcherfile.HostTmpPath, 0755); err != nil {
209209
t.Fatalf("Error creating host token path directory: %v", err)
210210
}
211211

@@ -245,7 +245,7 @@ func TestRefreshTokenWithSignedContainerCacheEnabled(t *testing.T) {
245245
}
246246

247247
func TestRefreshTokenError(t *testing.T) {
248-
if err := os.MkdirAll(launcherfile.HostTmpPath, 0744); err != nil {
248+
if err := os.MkdirAll(launcherfile.HostTmpPath, 0755); err != nil {
249249
t.Fatalf("Error creating host token path directory: %v", err)
250250
}
251251

launcher/launcher/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ func main() {
9292
return
9393
}
9494

95-
if err := os.MkdirAll(launcherfile.HostTmpPath, 0744); err != nil {
95+
if err := os.MkdirAll(launcherfile.HostTmpPath, 0755); err != nil {
9696
logger.Error(fmt.Sprintf("failed to create %s: %v", launcherfile.HostTmpPath, err))
9797
}
9898

0 commit comments

Comments
 (0)