Skip to content

Commit 6c518d9

Browse files
committed
Improve the Swift interface for GTMFetcherDecoratorFetcherWillStartCompletionHandler
This is a breaking change to Swift, but provides a much better apis to anyone trying to use the decorators from Swift. Part of #398
1 parent bd314c8 commit 6c518d9

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

Sources/Core/Public/GTMSessionFetcher/GTMSessionFetcher.h

+1-8
Original file line numberDiff line numberDiff line change
@@ -604,14 +604,7 @@ NSData *_Nullable GTMDataFromInputStream(NSInputStream *inputStream, NSError **o
604604
#endif
605605

606606
// Completion handler passed to -[GTMFetcherDecoratorProtocol fetcherWillStart:completionHandler:].
607-
608-
// TODO(https://github.com/google/gtm-session-fetcher/issues/398): Uncomment this when the next
609-
// major version bump happens, since this is an API breaking change for Swift clients.
610-
//
611-
// typedef void (^GTMFetcherDecoratorFetcherWillStartCompletionHandler)(NSURLRequest *_Nullable_result,
612-
// NSError *_Nullable);
613-
614-
typedef void (^GTMFetcherDecoratorFetcherWillStartCompletionHandler)(NSURLRequest *_Nullable,
607+
typedef void (^GTMFetcherDecoratorFetcherWillStartCompletionHandler)(NSURLRequest *_Nullable_result,
615608
NSError *_Nullable);
616609

617610
// Allows intercepting a request and optionally modifying it before the request (or a retry)

0 commit comments

Comments
 (0)