Skip to content

Commit 2351338

Browse files
authored
Improve DEBUG level logs; unify BUILD dependencies format (#64)
1 parent c1b905c commit 2351338

File tree

5 files changed

+15
-12
lines changed

5 files changed

+15
-12
lines changed

src/java/com/google/cloud/bigquery/dwhassessment/hooks/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ java_library(
2323
"//src/java/com/google/cloud/bigquery/dwhassessment/hooks/logger",
2424
"//src/java/com/google/cloud/bigquery/dwhassessment/hooks/logger/exception",
2525
"//src/java/com/google/cloud/bigquery/dwhassessment/hooks/logger/utils",
26-
"@maven//:org_apache_hadoop_hadoop_mapred_0_22_0",
26+
"@maven//:org_apache_hadoop_hadoop_mapred",
2727
"@maven//:org_apache_hive_hive_exec",
2828
"@maven//:org_slf4j_slf4j_api",
2929
],

src/java/com/google/cloud/bigquery/dwhassessment/hooks/logger/BUILD

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ java_library(
3131
"@maven//:org_apache_hadoop_hadoop_yarn_api",
3232
"@maven//:org_apache_hadoop_hadoop_yarn_client",
3333
"@maven//:org_apache_hive_hive_exec",
34-
"@maven//:org_apache_tez_tez_api_0_8_5",
34+
"@maven//:org_apache_tez_tez_api",
3535
"@maven//:org_slf4j_slf4j_api",
3636
],
3737
)

src/java/com/google/cloud/bigquery/dwhassessment/hooks/logger/EventLogger.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ public void handle(HookContext hookContext) {
137137
// before we start the pre hook processing and causes inconsistent events publishing.
138138
QueryPlan plan = hookContext.getQueryPlan();
139139
if (plan == null) {
140-
LOG.debug("Received null query plan.");
140+
LOG.debug("Received null query plan, skipping query event.");
141141
return;
142142
}
143143

@@ -147,7 +147,7 @@ public void handle(HookContext hookContext) {
147147
}
148148

149149
private void tryWriteEvent(GenericRecord event, HookType hookType) {
150-
LOG.debug("Trying to handle an event '{}' for query '{}'", hookType, event.get("QueryId"));
150+
LOG.debug("Trying to handle an event '{}' for record '{}'", hookType, event);
151151
try {
152152
// ScheduledThreadPoolExecutor uses an unbounded queue which cannot be replaced with a
153153
// bounded queue.
@@ -156,10 +156,13 @@ private void tryWriteEvent(GenericRecord event, HookType hookType) {
156156
logWriter.execute(() -> writeEventWithRetries(event));
157157
} else {
158158
LOG.warn(
159-
"Writer queue full. Ignoring event '{}' for query '{}'", hookType, event.get("QueryId"));
159+
"Writer queue full. Ignoring event '{}' for query '{}'",
160+
hookType,
161+
event.get("QueryId"));
160162
}
161163
} catch (RejectedExecutionException e) {
162-
LOG.warn("Writer queue full. Ignoring event '{}' for query '{}'", hookType, event.get("QueryId"));
164+
LOG.warn(
165+
"Writer queue full. Ignoring event '{}' for query '{}'", hookType, event.get("QueryId"));
163166
}
164167
}
165168

src/java/com/google/cloud/bigquery/dwhassessment/hooks/testing/BUILD

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,14 @@ package(default_visibility = ["//src:internal"])
1717

1818
java_library(
1919
name = "testing",
20-
srcs = glob(["*.java"]),
2120
testonly = 1,
21+
srcs = glob(["*.java"]),
2222
deps = [
2323
"//src/java/com/google/cloud/bigquery/dwhassessment/hooks/logger",
24-
"@maven_tests//:org_apache_avro_avro",
25-
"@maven_tests//:org_apache_hadoop_hadoop_common",
26-
"@maven_tests//:org_apache_hive_hive_exec_2_2_0",
2724
"@maven_tests//:com_google_guava_guava",
2825
"@maven_tests//:com_google_truth_truth",
26+
"@maven_tests//:org_apache_avro_avro",
27+
"@maven_tests//:org_apache_hadoop_hadoop_common",
28+
"@maven_tests//:org_apache_hive_hive_exec",
2929
],
3030
)

src/javatests/com/google/cloud/bigquery/dwhassessment/hooks/logger/BUILD

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ java_library(
5555
"@maven_tests//:org_apache_hadoop_hadoop_yarn_common",
5656
"@maven_tests//:org_apache_hive_hive_common",
5757
"@maven_tests//:org_apache_hive_hive_exec",
58-
"@maven_tests//:org_apache_tez_tez_api_0_8_5",
59-
"@maven_tests//:org_apache_tez_tez_dag_0_8_5",
58+
"@maven_tests//:org_apache_tez_tez_api",
59+
"@maven_tests//:org_apache_tez_tez_dag",
6060
"@maven_tests//:org_mockito_mockito_core",
6161
"@maven_tests//:org_slf4j_slf4j_api",
6262
],

0 commit comments

Comments
 (0)