Skip to content

Commit 2581ed3

Browse files
sfreilichcopybara-github
authored andcommitted
Tweak JNI interface to use more singleton wrappers around JNI
PiperOrigin-RevId: 828979174
1 parent f143320 commit 2581ed3

File tree

2 files changed

+28
-28
lines changed

2 files changed

+28
-28
lines changed

ink/geometry/internal/jni/intersects_jni.cc

Lines changed: 27 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ using ::ink::jni::CastToPartitionedMesh;
4141

4242
extern "C" {
4343

44-
JNI_METHOD(geometry, Intersection, jboolean, nativeVecSegmentIntersects)
44+
JNI_METHOD(geometry, IntersectionNative, jboolean, vecSegmentIntersects)
4545
(JNIEnv* env, jobject object, jfloat vec_x, jfloat vec_y,
4646
jfloat segment_start_x, jfloat segment_start_y, jfloat segment_end_x,
4747
jfloat segment_end_y) {
@@ -51,7 +51,7 @@ JNI_METHOD(geometry, Intersection, jboolean, nativeVecSegmentIntersects)
5151
return Intersects(point, segment);
5252
}
5353

54-
JNI_METHOD(geometry, Intersection, jboolean, nativeVecTriangleIntersects)
54+
JNI_METHOD(geometry, IntersectionNative, jboolean, vecTriangleIntersects)
5555
(JNIEnv* env, jobject object, jfloat vec_x, jfloat vec_y, jfloat triangle_p0_x,
5656
jfloat triangle_p0_y, jfloat triangle_p1_x, jfloat triangle_p1_y,
5757
jfloat triangle_p2_x, jfloat triangle_p2_y) {
@@ -62,7 +62,7 @@ JNI_METHOD(geometry, Intersection, jboolean, nativeVecTriangleIntersects)
6262
return Intersects(point, triangle);
6363
}
6464

65-
JNI_METHOD(geometry, Intersection, jboolean, nativeVecBoxIntersects)
65+
JNI_METHOD(geometry, IntersectionNative, jboolean, vecBoxIntersects)
6666
(JNIEnv* env, jobject object, jfloat vec_x, jfloat vec_y, jfloat box_x_min,
6767
jfloat box_y_min, jfloat box_x_max, jfloat box_y_max) {
6868
Point point{vec_x, vec_y};
@@ -71,7 +71,7 @@ JNI_METHOD(geometry, Intersection, jboolean, nativeVecBoxIntersects)
7171
return Intersects(point, rect);
7272
}
7373

74-
JNI_METHOD(geometry, Intersection, jboolean, nativeVecParallelogramIntersects)
74+
JNI_METHOD(geometry, IntersectionNative, jboolean, vecParallelogramIntersects)
7575
(JNIEnv* env, jobject object, jfloat vec_x, jfloat vec_y,
7676
jfloat parallelogram_center_x, jfloat parallelogram_center_y,
7777
jfloat parallelogram_width, jfloat parallelogram_height,
@@ -84,7 +84,7 @@ JNI_METHOD(geometry, Intersection, jboolean, nativeVecParallelogramIntersects)
8484
return Intersects(point, quad);
8585
}
8686

87-
JNI_METHOD(geometry, Intersection, jboolean, nativeSegmentSegmentIntersects)
87+
JNI_METHOD(geometry, IntersectionNative, jboolean, segmentSegmentIntersects)
8888
(JNIEnv* env, jobject object, jfloat segment_1_start_x,
8989
jfloat segment_1_start_y, jfloat segment_1_end_x, jfloat segment_1_end_y,
9090
jfloat segment_2_start_x, jfloat segment_2_start_y, jfloat segment_2_end_x,
@@ -96,7 +96,7 @@ JNI_METHOD(geometry, Intersection, jboolean, nativeSegmentSegmentIntersects)
9696
return Intersects(segment1, segment2);
9797
}
9898

99-
JNI_METHOD(geometry, Intersection, jboolean, nativeSegmentTriangleIntersects)
99+
JNI_METHOD(geometry, IntersectionNative, jboolean, segmentTriangleIntersects)
100100
(JNIEnv* env, jobject object, jfloat segment_start_x, jfloat segment_start_y,
101101
jfloat segment_end_x, jfloat segment_end_y, jfloat triangle_p0_x,
102102
jfloat triangle_p0_y, jfloat triangle_p1_x, jfloat triangle_p1_y,
@@ -109,7 +109,7 @@ JNI_METHOD(geometry, Intersection, jboolean, nativeSegmentTriangleIntersects)
109109
return Intersects(segment, triangle);
110110
}
111111

112-
JNI_METHOD(geometry, Intersection, jboolean, nativeSegmentBoxIntersects)
112+
JNI_METHOD(geometry, IntersectionNative, jboolean, segmentBoxIntersects)
113113
(JNIEnv* env, jobject object, jfloat segment_start_x, jfloat segment_start_y,
114114
jfloat segment_end_x, jfloat segment_end_y, jfloat box_x_min, jfloat box_y_min,
115115
jfloat box_x_max, jfloat box_y_max) {
@@ -120,8 +120,8 @@ JNI_METHOD(geometry, Intersection, jboolean, nativeSegmentBoxIntersects)
120120
return Intersects(segment, rect);
121121
}
122122

123-
JNI_METHOD(geometry, Intersection, jboolean,
124-
nativeSegmentParallelogramIntersects)
123+
JNI_METHOD(geometry, IntersectionNative, jboolean,
124+
segmentParallelogramIntersects)
125125
(JNIEnv* env, jobject object, jfloat segment_start_x, jfloat segment_start_y,
126126
jfloat segment_end_x, jfloat segment_end_y, jfloat parallelogram_center_x,
127127
jfloat parallelogram_center_y, jfloat parallelogram_width,
@@ -136,7 +136,7 @@ JNI_METHOD(geometry, Intersection, jboolean,
136136
return Intersects(segment, quad);
137137
}
138138

139-
JNI_METHOD(geometry, Intersection, jboolean, nativeTriangleTriangleIntersects)
139+
JNI_METHOD(geometry, IntersectionNative, jboolean, triangleTriangleIntersects)
140140
(JNIEnv* env, jobject object, jfloat triangle_1_p0_x, jfloat triangle_1_p0_y,
141141
jfloat triangle_1_p1_x, jfloat triangle_1_p1_y, jfloat triangle_1_p2_x,
142142
jfloat triangle_1_p2_y, jfloat triangle_2_p0_x, jfloat triangle_2_p0_y,
@@ -151,7 +151,7 @@ JNI_METHOD(geometry, Intersection, jboolean, nativeTriangleTriangleIntersects)
151151
return Intersects(triangle1, triangle2);
152152
}
153153

154-
JNI_METHOD(geometry, Intersection, jboolean, nativeTriangleBoxIntersects)
154+
JNI_METHOD(geometry, IntersectionNative, jboolean, triangleBoxIntersects)
155155
(JNIEnv* env, jobject object, jfloat triangle_p0_x, jfloat triangle_p0_y,
156156
jfloat triangle_p1_x, jfloat triangle_p1_y, jfloat triangle_p2_x,
157157
jfloat triangle_p2_y, jfloat box_x_min, jfloat box_y_min, jfloat box_x_max,
@@ -164,8 +164,8 @@ JNI_METHOD(geometry, Intersection, jboolean, nativeTriangleBoxIntersects)
164164
return Intersects(triangle, rect);
165165
}
166166

167-
JNI_METHOD(geometry, Intersection, jboolean,
168-
nativeTriangleParallelogramIntersects)
167+
JNI_METHOD(geometry, IntersectionNative, jboolean,
168+
triangleParallelogramIntersects)
169169
(JNIEnv* env, jobject object, jfloat triangle_p0_x, jfloat triangle_p0_y,
170170
jfloat triangle_p1_x, jfloat triangle_p1_y, jfloat triangle_p2_x,
171171
jfloat triangle_p2_y, jfloat parallelogram_center_x,
@@ -182,7 +182,7 @@ JNI_METHOD(geometry, Intersection, jboolean,
182182
return Intersects(triangle, quad);
183183
}
184184

185-
JNI_METHOD(geometry, Intersection, jboolean, nativeBoxBoxIntersects)
185+
JNI_METHOD(geometry, IntersectionNative, jboolean, boxBoxIntersects)
186186
(JNIEnv* env, jobject object, jfloat box_1_x_min, jfloat box_1_y_min,
187187
jfloat box_1_x_max, jfloat box_1_y_max, jfloat box_2_x_min, jfloat box_2_y_min,
188188
jfloat box_2_x_max, jfloat box_2_y_max) {
@@ -193,7 +193,7 @@ JNI_METHOD(geometry, Intersection, jboolean, nativeBoxBoxIntersects)
193193
return Intersects(rect1, rect2);
194194
}
195195

196-
JNI_METHOD(geometry, Intersection, jboolean, nativeBoxParallelogramIntersects)
196+
JNI_METHOD(geometry, IntersectionNative, jboolean, boxParallelogramIntersects)
197197
(JNIEnv* env, jobject object, jfloat box_x_min, jfloat box_y_min,
198198
jfloat box_x_max, jfloat box_y_max, jfloat parallelogram_center_x,
199199
jfloat parallelogram_center_y, jfloat parallelogram_width,
@@ -208,8 +208,8 @@ JNI_METHOD(geometry, Intersection, jboolean, nativeBoxParallelogramIntersects)
208208
return Intersects(rect, quad);
209209
}
210210

211-
JNI_METHOD(geometry, Intersection, jboolean,
212-
nativeParallelogramParallelogramIntersects)
211+
JNI_METHOD(geometry, IntersectionNative, jboolean,
212+
parallelogramParallelogramIntersects)
213213
(JNIEnv* env, jobject object, jfloat parallelogram_1_center_x,
214214
jfloat parallelogram_1_center_y, jfloat parallelogram_1_width,
215215
jfloat parallelogram_1_height, jfloat parallelogram_1_angle_in_radian,
@@ -230,7 +230,7 @@ JNI_METHOD(geometry, Intersection, jboolean,
230230
return Intersects(quad1, quad2);
231231
}
232232

233-
JNI_METHOD(geometry, Intersection, jboolean, nativePartitionedMeshVecIntersects)
233+
JNI_METHOD(geometry, IntersectionNative, jboolean, partitionedMeshVecIntersects)
234234
(JNIEnv* env, jobject object, jlong partitioned_mesh_native_pointer,
235235
jfloat vec_x, jfloat vec_y, jfloat vec_to_partitionedMesh_transform_a,
236236
jfloat vec_to_partitionedMesh_transform_b,
@@ -248,8 +248,8 @@ JNI_METHOD(geometry, Intersection, jboolean, nativePartitionedMeshVecIntersects)
248248
point, CastToPartitionedMesh(partitioned_mesh_native_pointer), transform);
249249
}
250250

251-
JNI_METHOD(geometry, Intersection, jboolean,
252-
nativePartitionedMeshSegmentIntersects)
251+
JNI_METHOD(geometry, IntersectionNative, jboolean,
252+
partitionedMeshSegmentIntersects)
253253
(JNIEnv* env, jobject object, jlong partitioned_mesh_native_pointer,
254254
jfloat segment_start_x, jfloat segment_start_y, jfloat segment_end_x,
255255
jfloat segment_end_y, jfloat segment_to_partitionedMesh_transform_a,
@@ -271,8 +271,8 @@ JNI_METHOD(geometry, Intersection, jboolean,
271271
transform);
272272
}
273273

274-
JNI_METHOD(geometry, Intersection, jboolean,
275-
nativePartitionedMeshTriangleIntersects)
274+
JNI_METHOD(geometry, IntersectionNative, jboolean,
275+
partitionedMeshTriangleIntersects)
276276
(JNIEnv* env, jobject object, jlong partitioned_mesh_native_pointer,
277277
jfloat triangle_p0_x, jfloat triangle_p0_y, jfloat triangle_p1_x,
278278
jfloat triangle_p1_y, jfloat triangle_p2_x, jfloat triangle_p2_y,
@@ -296,7 +296,7 @@ JNI_METHOD(geometry, Intersection, jboolean,
296296
transform);
297297
}
298298

299-
JNI_METHOD(geometry, Intersection, jboolean, nativePartitionedMeshBoxIntersects)
299+
JNI_METHOD(geometry, IntersectionNative, jboolean, partitionedMeshBoxIntersects)
300300
(JNIEnv* env, jobject object, jlong partitioned_mesh_native_pointer,
301301
jfloat box_x_min, jfloat box_y_min, jfloat box_x_max, jfloat box_y_max,
302302
jfloat box_to_partitionedMesh_transform_a,
@@ -315,8 +315,8 @@ JNI_METHOD(geometry, Intersection, jboolean, nativePartitionedMeshBoxIntersects)
315315
rect, CastToPartitionedMesh(partitioned_mesh_native_pointer), transform);
316316
}
317317

318-
JNI_METHOD(geometry, Intersection, jboolean,
319-
nativePartitionedMeshParallelogramIntersects)
318+
JNI_METHOD(geometry, IntersectionNative, jboolean,
319+
partitionedMeshParallelogramIntersects)
320320
(JNIEnv* env, jobject object, jlong partitioned_mesh_native_pointer,
321321
jfloat parallelogram_center_x, jfloat parallelogram_center_y,
322322
jfloat parallelogram_width, jfloat parallelogram_height,
@@ -341,8 +341,8 @@ JNI_METHOD(geometry, Intersection, jboolean,
341341
quad, CastToPartitionedMesh(partitioned_mesh_native_pointer), transform);
342342
}
343343

344-
JNI_METHOD(geometry, Intersection, jboolean,
345-
nativePartitionedMeshPartitionedMeshIntersects)
344+
JNI_METHOD(geometry, IntersectionNative, jboolean,
345+
partitionedMeshPartitionedMeshIntersects)
346346
(JNIEnv* env, jobject object, jlong this_partitioned_mesh_native_pointer,
347347
jlong other_partitioned_mesh_native_pointer, jfloat this_to_common_transform_a,
348348
jfloat this_to_common_transform_b, jfloat this_to_common_transform_c,

ink/rendering/skia/common_internal/jni/canvas_mesh_renderer_jni.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ absl::StatusOr<MeshSpecificationData> GetMeshSpecificationData(
4343

4444
extern "C" {
4545

46-
JNI_METHOD(rendering_android_canvas_internal, CanvasMeshRenderer, void,
46+
JNI_METHOD(rendering_android_canvas_internal, CanvasMeshRendererNative, void,
4747
fillSkiaMeshSpecData)
4848
(JNIEnv* env, jobject object, jlong raw_ptr_to_mesh_format, jboolean packed,
4949
jintArray attribute_types_out, jintArray attribute_offsets_out,

0 commit comments

Comments
 (0)