Consider adding one more indentation after if

[ahakanbaba]

Please consider the following different ways of writing if

{
    replicas: {
        build: if isCanary then 0
        else 1,

        dev: if isCanary then
            0
        else
            1,

        prod: if isCanary
        then 0
        else 1,

        perf: if isCanary
        then
            0
        else
            1,

    },
}

jsonnet fmt aligns then and else with the key name.

Did you consider adding one more indent to the blocks starting with then and else.
How about the following indentation assuming --indent 4 is passed to jsonnet fmt

{
    replicas: {
        build: if isCanary then 0
            else 1,

        dev: if isCanary then
                0
            else
                1,

        prod: if isCanary
            then 0
            else 1,

        perf: if isCanary
            then
                0
            else
                1,
    },
}

[ahakanbaba]

If the if block is used somewhere else, not immediately after a key, the same indentation rules actually look nice, I think

For example:

{
    image: image.url(
        app.something,
        if imageTag != null then
            imageTag
        else if isCanary then
            "other thing"
        else
            "some other thing",
    ),
}

[sbarzowski]

I'd say it's a problem with formatting object fields rather than if.

[sparkprime]

In your first comment, I think both the current behavior and your proposed rules look pretty ugly. In that case it's probably better to rewrite it to put the if on a new line. All of the following look much better:

{
  replicas: {
    build:
      if isCanary then 0
      else 1,

    dev:
      if isCanary then
        0
      else
        1,

    prod:
      if isCanary
      then 0
      else 1,

    perf:
      if isCanary
      then
        0
      else
        1,
  },
}

It's instructive to play with the formatter demo on http://jsonnet.org/learning/tools.html

[sparkprime]

In your second comment, that is the current behavior so 👍 etc

[sparkprime]

Oh maybe if someone puts a newline before the 'then' but not before the 'if' we should treat that like we do in the case of an array like

[
  1, 2,
  3
]

[sparkprime]

I.e. add a newline before the if too