Concatenation with if conditions could be indented better

[ahakanbaba]

Consider to following output for jsonnet fmt --indent 4 --string-style l

local tcm = if (env.isDev) then [] else [] +
                                        if (env.isDev || env.isStaging) then [] else [] +
                                                                                     [
                                                                                         'app',
                                                                                     ];

local tcm2 = "a" + "b " +
             "c";

local tcm3 = ["a"] + ["b "] +
             ["c"];

{
}

Once if conditions are involved with concatenations, it looks like jsonnet fmt does not indent correctly.

[sbarzowski]

How do you think the perfect indentation of this example would look like?

[ahakanbaba]

I expected the indentation to be similar to tcm3 variable.
in tcm3 the ["c"] is aligned with ["a"].

local tcm3 = ["a"] + ["b "] +
             ["c"];

I guess jsonnet fmt is doing something similar for tcm too.
The if of the next line is aligned with the next token after the else from the previous line.

local tcm = if (env.isDev) then [] else [] +
                                        if (env.i

I would have expected the if in the next line to be aligned with the if of the previous line.

local tcm = if (env.isDev) then [] else [] +
            if (env.isDev || env.isStaging) then [] else [] +
            [
                'app',
            ];

Having said that, it can be more complicated than that. There are other ways of writing this.
Does aligning if to if improve how the following is formatted now ? I am not sure.

local tcm4 = if (env.isDev) then
    []
else
    [] +
    if (env.isDev || env.isStaging) then
        []
    else
        [] +
        [
            'app',
        ];

[sparkprime]

All of those look reasonable given that the else parses greedily.

What you're suggesting would be more appropriate for code like:

local tcm = (if (env.isDev) then [] else []) +
            (if (env.isDev || env.isStaging) then [] else []) +
            [
                'app',
            ];
true

[sparkprime]

@ahakanbaba What do you think about my last comment?