Add the wrapped literal to the display name of kd.literal

If the debug repr is used, the literal currently shows an opaque name making introspection harder. This change aims to make it more clear which value is being shown in order to simplify debugging. Note that for e.g. `repr(kd.expr.literal(kd.slice(1)))`, the pretty print version is shown rather than the debug one, and is not affected by this change.

PiperOrigin-RevId: 718262183
Change-Id: I32d7e589c5839bc40db3ab96b8aa8a634fd1de4b

Author: felbro

koladata/expr/expr_operators.cc

@@ -15,6 +15,7 @@
 #include "koladata/expr/expr_operators.h"
 
 #include <cstdint>
+#include <string>
 #include <utility>
 
 #include "absl/status/status.h"
@@ -87,8 +88,8 @@ absl::StatusOr<arolla::expr::ExprAttributes> InputOperator::InferAttributes(
 
 LiteralOperator::LiteralOperator(arolla::TypedValue value)
     : arolla::expr::ExprOperatorWithFixedSignature(
-          "koda_internal.literal", arolla::expr::ExprOperatorSignature{},
-          "Koda literal.",
+          absl::StrFormat("koda_internal.literal[%s]", value.Repr()),
+          arolla::expr::ExprOperatorSignature{}, "Koda literal.",
           arolla::FingerprintHasher("::koladata::expr::LiteralOperator")
               .Combine(value.GetFingerprint())
               .Finish()),

py/koladata/types/BUILD

@@ -593,7 +593,6 @@ py_test(
         ":data_slice",
         ":literal_operator",
         ":qtypes",
-        ":schema_constants",
         "//py/koladata/expr:view",
         "//py/koladata/operators:eager_op_utils",
         "//py/koladata/operators:kde_operators",

py/koladata/types/literal_operator_test.py

@@ -12,7 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-"""Tests for literal_operator."""
+import re
 
 from absl.testing import absltest
 from absl.testing import parameterized
@@ -25,7 +25,6 @@
 from koladata.types import data_slice
 from koladata.types import literal_operator
 from koladata.types import qtypes
-from koladata.types import schema_constants
 
 
 kd = eager_op_utils.operators_container('kd')
@@ -144,6 +143,16 @@ def test_literal_operator_init(self):
         arolla.eval(op()), arolla.int32(1)
     )
 
+  def test_op_binding_debug_string(self):
+    # This uses a debug repr which avoids pretty printing. This ensures that we
+    # include the wrapped value in the repr.
+    x = literal_operator.literal(arolla.int32(1))
+    self.assertEqual(x.op.display_name, 'koda_internal.literal[1]')
+    with self.assertRaisesRegex(
+        ValueError, re.escape('koda_internal.literal[1]():INT32')
+    ):
+      arolla.M.annotation.qtype(x, arolla.FLOAT32)
+
   @parameterized.parameters(
       (arolla.L.x,),
       (1,),