Remove DCHECKs for dict.Set(None, value), dict.Set(float{x}, value). Unsupported keys will be silently ignored both in debug and release builds.

petrmikheev · copybara-github · commit 0c77bc3e2a6b · 2026-02-16T06:13:04.000-08:00
Removing DCHECKs seems to be the most consistent solution, given that in databag.cc in some codepaths we already ignore missing keys.

PiperOrigin-RevId: 870859805
Change-Id: I6abf97706528c21ed3acb248b17e050dc0c894a5
diff --git a/koladata/internal/dict.h b/koladata/internal/dict.h
@@ -69,12 +69,10 @@ class Dict {
   void Set(const T& key, DataItem value) {
     if constexpr (std::is_same_v<T, DataItem>) {
       if (IsUnsupportedDataItemKeyType(key)) {
-        DCHECK(false);
         return;
       }
     }
     using KeyT = arolla::meta::strip_template_t<DataItem::View, T>;
-    DCHECK(!IsUnsupportedKeyType<KeyT>());
     if constexpr (!IsUnsupportedKeyType<KeyT>()) {
       data_[key] = std::move(value);
     }
@@ -100,13 +98,11 @@ class Dict {
   const DataItem& GetOrAssign(const T& key, ValueT&& value) {
     if constexpr (std::is_same_v<T, DataItem>) {
       if (IsUnsupportedDataItemKeyType(key)) {
-        DCHECK(false);
         return *empty_item_;
       }
     }
     using KeyT = arolla::meta::strip_template_t<DataItem::View, T>;
     if constexpr (IsUnsupportedKeyType<KeyT>()) {
-      DCHECK(false);
       return *empty_item_;
     }
     if (parent_ == nullptr) {

Original file line number	Diff line number	Diff line change
`@@ -69,12 +69,10 @@ class Dict {`
`69`	`69`	`void Set(const T& key, DataItem value) {`
`70`	`70`	`if constexpr (std::is_same_v<T, DataItem>) {`
`71`	`71`	`if (IsUnsupportedDataItemKeyType(key)) {`
`72`		`- DCHECK(false);`
`73`	`72`	`return;`
`74`	`73`	`}`
`75`	`74`	`}`
`76`	`75`	`using KeyT = arolla::meta::strip_template_t<DataItem::View, T>;`
`77`		`- DCHECK(!IsUnsupportedKeyType<KeyT>());`
`78`	`76`	`if constexpr (!IsUnsupportedKeyType<KeyT>()) {`
`79`	`77`	`data_[key] = std::move(value);`
`80`	`78`	`}`
`@@ -100,13 +98,11 @@ class Dict {`
`100`	`98`	`const DataItem& GetOrAssign(const T& key, ValueT&& value) {`
`101`	`99`	`if constexpr (std::is_same_v<T, DataItem>) {`
`102`	`100`	`if (IsUnsupportedDataItemKeyType(key)) {`
`103`		`- DCHECK(false);`
`104`	`101`	`return *empty_item_;`
`105`	`102`	`}`
`106`	`103`	`}`
`107`	`104`	`using KeyT = arolla::meta::strip_template_t<DataItem::View, T>;`
`108`	`105`	`if constexpr (IsUnsupportedKeyType<KeyT>()) {`
`109`		`- DCHECK(false);`
`110`	`106`	`return *empty_item_;`
`111`	`107`	`}`
`112`	`108`	`if (parent_ == nullptr) {`