Remove the with_ancestors argument from DataSliceManagerView.get().

The `with_ancestors` parameter no longer makes sense now that there is a `populate` arg. A better name for it would be `return_populated_root`. But removing it completely is cleaner, since a call of the form `view.get(with_ancestors=True)` is equivalent to `root.get(populate=[view])`. If you don't have the root already, it can easily be obtained using `view.get_root()`.

PiperOrigin-RevId: 861678350
Change-Id: Iafaa1e398f36157cdd4690e2751d5d1a88b13c0f

Author: svsgoogle

py/koladata/ext/persisted_data/colab/Persisted_incremental_DataSlice_basics.ipynb

@@ -726,7 +726,7 @@
         }
       ],
       "source": [
-        "root.query[:].doc[:].get_data_slice(with_ancestors=True, with_descendants=True)"
+        "root.get_data_slice(populate_including_descendants=[root.query[:].doc[:]])"
       ]
     },
     {

py/koladata/ext/persisted_data/data_slice_manager_view.py

@@ -98,7 +98,6 @@ def get_schema(self) -> kd.types.SchemaItem:
   def get_data_slice(
       self,
       *,
-      with_ancestors: bool = False,
       with_descendants: bool = False,
       populate: Collection[DataSliceManagerView] | None = None,
       populate_including_descendants: (
@@ -110,20 +109,13 @@ def get_data_slice(
     The view path must be valid, i.e. self.is_view_valid() must be True.
 
     Args:
-      with_ancestors: If True, then the DataSlice will include the data of all
-        the ancestors of the view path up to the root. Otherwise, the returned
-        DataSlice will be start at this view path, and only its data and the
-        data of its requested descendants (if any) will be accessible in the
-        result.
       with_descendants: If True, then the DataSlice will include the data of all
         the descendants of the view path.
-      populate: Additional views whose DataSlicePaths will be populated. If
-        these paths are not descendants of this view's path, then you have to
-        pass with_ancestors=True to see the data in the returned DataSlice.
+      populate: Additional views whose DataSlicePaths will be populated. Their
+        paths must be descendants of this view's path for you to see their data
+        in the returned DataSlice.
       populate_including_descendants: Additional views whose DataSlicePaths and
-        all their descendants will be populated. If these paths are not
-        descendants of this view's path, then you have to pass
-        with_ancestors=True to see the data in the returned DataSlice.
+        all their descendants will be populated.
     """
     self._check_path_from_root_is_valid()
     populate = {v.get_path_from_root() for v in populate or []}
@@ -138,14 +130,11 @@ def get_data_slice(
         populate=populate,
         populate_including_descendants=populate_including_descendants,
     )
-    if with_ancestors:
-      return ds
     return self._path_from_root.evaluate(ds)
 
   def get(
       self,
       *,
-      with_ancestors: bool = False,
       with_descendants: bool = False,
       populate: Collection[DataSliceManagerView] | None = None,
       populate_including_descendants: (
@@ -157,23 +146,15 @@ def get(
     The view path must be valid, i.e. self.is_view_valid() must be True.
 
     Args:
-      with_ancestors: If True, then the DataSlice will include the data of all
-        the ancestors of the view path up to the root. Otherwise, the returned
-        DataSlice will be start at this view path, and only its data and the
-        data of its requested descendants (if any) will be accessible in the
-        result.
       with_descendants: If True, then the DataSlice will include the data of all
         the descendants of the view path.
-      populate: Additional views whose DataSlicePaths will be populated. If
-        these paths are not descendants of this view's path, then you have to
-        pass with_ancestors=True to see the data in the returned DataSlice.
+      populate: Additional views whose DataSlicePaths will be populated. Their
+        paths must be descendants of this view's path for you to see their data
+        in the returned DataSlice.
       populate_including_descendants: Additional views whose DataSlicePaths and
-        all their descendants will be populated. If these paths are not
-        descendants of this view's path, then you have to pass
-        with_ancestors=True to see the data in the returned DataSlice.
+        all their descendants will be populated.
     """
     return self.get_data_slice(
-        with_ancestors=with_ancestors,
         with_descendants=with_descendants,
         populate=populate,
         populate_including_descendants=populate_including_descendants,

py/koladata/ext/persisted_data/data_slice_manager_view_test.py

@@ -71,7 +71,7 @@ def test_typical_usage(self):
     )
     restricted_query_schema = kd.named_schema('query', query_id=kd.INT32)
     kd.testing.assert_equivalent(
-        queries.query_id.get(with_ancestors=True),
+        root.get(populate=[queries.query_id]),
         kd.new(
             query=kd.list([
                 restricted_query_schema.new(query_id=0),
@@ -1800,19 +1800,17 @@ def test_get_with_populate_arguments(self):
 
     kd.testing.assert_equivalent(
         doc_view.doc_id.get(
-            # By default, with_ancestors=False. Since the query text is not a
-            # descendant of the doc_id, only the doc_id will be visible in the
-            # result.
+            # Since the query text is not a descendant of the doc_id, only the
+            # doc_id will be visible in the result.
             populate=[query_view.text],
         ),
         query_list[:].doc[:].doc_id,
     )
     kd.testing.assert_equivalent(
-        doc_view.doc_id.get(
+        root_view.get(
             # This time we request the result to start from the root, so the
             # query text will be visible in the result.
-            with_ancestors=True,
-            populate=[query_view.text],
+            populate=[query_view.text, doc_view.doc_id],
         ),
         kd.new(
             query=kd.list([
@@ -1865,22 +1863,20 @@ def test_get_with_populate_arguments(self):
         ids_equality=True,
     )
     kd.testing.assert_equivalent(
-        doc_view.get(
-            with_ancestors=True, populate_including_descendants=[query_view]
+        root_view.get(
+            populate=[doc_view], populate_including_descendants=[query_view]
         ),
         root_view.get(with_descendants=True),
         ids_equality=True,
     )
     kd.testing.assert_equivalent(
-        query_view.query_id.get(
-            with_ancestors=True,
-            populate=[query_view.text],
+        root_view.get(
+            populate=[query_view.text, query_view.query_id],
             populate_including_descendants=[doc_view],
         ),
-        doc_view.get(
-            with_ancestors=True,
-            with_descendants=True,
+        root_view.get(
             populate=[query_view.text, query_view.query_id],
+            populate_including_descendants=[doc_view],
         ),
         ids_equality=True,
     )