Rename SchemaHelper.is_valid_data_slice_path() to SchemaHelper.exists().

This change makes the method name more concise and aligns with the common "exists" terminology used in data management contexts.

PiperOrigin-RevId: 856108486
Change-Id: I7bc20cdd210cc931655e4a1dfcbc08b26c26fe3e

Author: svsgoogle

py/koladata/ext/persisted_data/bare_root_initial_data_manager.py

@@ -119,7 +119,7 @@ def get_data_slice_for_schema_node_names(
     return self._root_item
 
   def exists(self, path: data_slice_path_lib.DataSlicePath) -> bool:
-    return self._schema_helper.is_valid_data_slice_path(path)
+    return self._schema_helper.exists(path)
 
   def get_data_slice(
       self,

py/koladata/ext/persisted_data/persisted_incremental_data_slice_manager.py

@@ -463,7 +463,7 @@ def generate_paths(
 
   def exists(self, path: data_slice_path_lib.DataSlicePath) -> bool:
     """Returns whether the given data slice path exists for this manager."""
-    return self._schema_helper.is_valid_data_slice_path(path)
+    return self._schema_helper.exists(path)
 
   def get_data_slice(
       self,

py/koladata/ext/persisted_data/persisted_incremental_data_slice_manager_test.py

@@ -136,7 +136,7 @@ def is_loaded_data_slice_path(
   """Returns whether the given data slice path is loaded."""
   return schema_helper_lib.SchemaHelper(
       get_loaded_schema(manager)
-  ).is_valid_data_slice_path(path)
+  ).exists(path)
 
 
 class PersistedIncrementalDataSliceManagerTest(parameterized.TestCase):

py/koladata/ext/persisted_data/schema_helper.py

@@ -776,9 +776,7 @@ def generate_available_data_slice_paths(
         self._schema, max_depth=max_depth
     )
 
-  def is_valid_data_slice_path(
-      self, data_slice_path: data_slice_path_lib.DataSlicePath
-  ) -> bool:
+  def exists(self, data_slice_path: data_slice_path_lib.DataSlicePath) -> bool:
     try:
       self.get_schema_node_name_for_data_slice_path(data_slice_path)
       return True
@@ -804,12 +802,12 @@ def get_schema_node_names_needed_to(
     populate = set(populate or [])
     populate_including_descendants = set(populate_including_descendants or [])
     for path in populate:
-      if not self.is_valid_data_slice_path(path):
+      if not self.exists(path):
         raise ValueError(
             f"data slice path '{path}' passed in argument 'populate' is invalid"
         )
     for path in populate_including_descendants:
-      if not self.is_valid_data_slice_path(path):
+      if not self.exists(path):
         raise ValueError(
             f"data slice path '{path}' passed in argument"
             " 'populate_including_descendants' is invalid"

py/koladata/ext/persisted_data/schema_helper_test.py

@@ -685,7 +685,7 @@ def test_generate_available_data_paths(self):
     )
 
     for data_path in helper.generate_available_data_slice_paths(max_depth=7):
-      self.assertTrue(helper.is_valid_data_slice_path(data_path))
+      self.assertTrue(helper.exists(data_path))
 
   def test_generate_available_data_paths_for_dict_schema(self):
     dict_schema = kd.dict_schema(kd.STRING, kd.STRING)
@@ -700,7 +700,7 @@ def test_generate_available_data_paths_for_dict_schema(self):
     )
 
     for data_path in helper.generate_available_data_slice_paths(max_depth=7):
-      self.assertTrue(helper.is_valid_data_slice_path(data_path))
+      self.assertTrue(helper.exists(data_path))
 
   def test_get_affected_schema_node_names(self):
     root = kd.new()
@@ -947,32 +947,32 @@ def test_schema_helper_is_valid_data_path(self):
     helper = schema_helper.SchemaHelper(schema)
 
     self.assertTrue(
-        helper.is_valid_data_slice_path(DataSlicePath.from_actions([]))
+        helper.exists(DataSlicePath.from_actions([]))
     )
     self.assertTrue(
-        helper.is_valid_data_slice_path(
+        helper.exists(
             DataSlicePath.from_actions([GetAttr('foo')])
         )
     )
     self.assertTrue(
-        helper.is_valid_data_slice_path(
+        helper.exists(
             DataSlicePath.from_actions([GetAttr('bar')])
         )
     )
     self.assertTrue(
-        helper.is_valid_data_slice_path(
+        helper.exists(
             DataSlicePath.from_actions([GetAttr('bar'), ListExplode()])
         )
     )
 
     # These are not valid data slice paths for the schema.
     self.assertFalse(
-        helper.is_valid_data_slice_path(
+        helper.exists(
             DataSlicePath.from_actions([GetAttr('foo'), ListExplode()])
         )
     )
     self.assertFalse(
-        helper.is_valid_data_slice_path(
+        helper.exists(
             DataSlicePath.from_actions(
                 [GetAttr('bar'), ListExplode(), DictGetKeys()]
             )

py/koladata/ext/persisted_data/simple_in_memory_data_slice_manager.py

@@ -50,7 +50,7 @@ def generate_paths(
     )
 
   def exists(self, path: data_slice_path_lib.DataSlicePath) -> bool:
-    return self._schema_helper().is_valid_data_slice_path(path)
+    return self._schema_helper().exists(path)
 
   def get_data_slice(
       self,