Improve the error message for schema embedding

PiperOrigin-RevId: 718465534
Change-Id: I46260fc05d7761f9c080b077034ce4d7d3a123a2

Author: dilumich

koladata/data_slice.cc

@@ -1341,10 +1341,10 @@ absl::Status DataSlice::DelAttr(absl::string_view attr_name) const {
 absl::StatusOr<DataSlice> DataSlice::EmbedSchema(bool overwrite) const {
   if (!GetSchemaImpl().is_primitive_schema() &&
       !GetSchemaImpl().is_struct_schema() && GetSchemaImpl() != schema::kNone) {
-    return absl::InvalidArgumentError(
-        absl::StrFormat("schema embedding is only supported for primitive and "
-                        "entity schemas, got %v",
-                        GetSchemaImpl()));
+    return absl::InvalidArgumentError(absl::StrFormat(
+        "schema embedding is only supported for a DataSlice with primitive, "
+        "entity, list or dict schemas, got %v",
+        GetSchemaImpl()));
   }
   return ToObject(*this, /*validate_schema=*/!overwrite);
 }

koladata/data_slice_test.cc

@@ -1526,10 +1526,12 @@ TEST(DataSliceTest, EmbedSchema_MixedNotAllowed) {
   auto values = test::MixedDataSlice<int, ObjectId>(
       {1, std::nullopt}, {std::nullopt, internal::AllocateSingleObject()},
       schema::kAny);
-  EXPECT_THAT(values.EmbedSchema(),
-              StatusIs(absl::StatusCode::kInvalidArgument,
-                       "schema embedding is only supported for primitive and "
-                       "entity schemas, got ANY"));
+  EXPECT_THAT(
+      values.EmbedSchema(),
+      StatusIs(
+          absl::StatusCode::kInvalidArgument,
+          "schema embedding is only supported for a DataSlice with primitive, "
+          "entity, list or dict schemas, got ANY"));
 }
 
 TEST(DataSliceTest, EmbedSchema_Object_Errors) {

koladata/object_factories_test.cc

@@ -1141,9 +1141,10 @@ TEST(ObjectCreatorTest, ObjectConverterError) {
   EXPECT_THAT(
       ObjectCreator::ConvertWithoutAdopt(
           db, test::DataSlice<int>({1}, schema::kAny)),
-      StatusIs(absl::StatusCode::kInvalidArgument,
-               "schema embedding is only supported for primitive and "
-               "entity schemas, got ANY"));
+      StatusIs(
+          absl::StatusCode::kInvalidArgument,
+          "schema embedding is only supported for a DataSlice with primitive, "
+          "entity, list or dict schemas, got ANY"));
 }
 
 TEST(UuObjectCreatorTest, DataSlice) {

py/koladata/functions/tests/embed_schema_test.py

@@ -12,8 +12,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-"""Tests for embed_schema."""
-
 from absl.testing import absltest
 from arolla import arolla
 from koladata.functions import functions as fns
@@ -48,8 +46,8 @@ def test_primitive(self):
   def test_error(self):
     with self.assertRaisesRegex(
         ValueError,
-        'schema embedding is only supported for primitive and entity schemas,'
-        ' got ANY',
+        'schema embedding is only supported for a DataSlice with primitive, '
+        'entity, list or dict schemas, got ANY',
     ):
       fns.embed_schema(ds([1, 'a']).as_any())