Omit schema attributes with None values from DataSlice repr.

PiperOrigin-RevId: 863378714
Change-Id: I3a189bf53197dcd9c896bd28f76d280341a8096f

Author: Mikester95

koladata/data_slice_repr.cc

@@ -611,12 +611,17 @@ absl::StatusOr<std::vector<std::string>> AttrsToStrParts(
       break;
     }
     ASSIGN_OR_RETURN(DataSlice value, ds.GetAttr(attr_name));
-    ASSIGN_OR_RETURN(std::string value_str,
-                     DataItemToStr(value.item(), value.GetSchemaImpl(), db,
-                                   option, wrapping));
-    parts.emplace_back(wrapping.FormatSchemaAttrAndValue(
-        attr_name, value_str, value.item().is_list()));
-    ++item_count;
+    bool skip_none_values =
+        ds.GetSchemaImpl() != schema::kObject && option.show_schema;
+    // We skip showing attrs with the value None.
+    if (!value.IsEmpty() || !skip_none_values) {
+      ASSIGN_OR_RETURN(std::string value_str,
+                       DataItemToStr(value.item(), value.GetSchemaImpl(), db,
+                                     option, wrapping));
+      parts.emplace_back(wrapping.FormatSchemaAttrAndValue(
+          attr_name, value_str, value.item().is_list()));
+      ++item_count;
+    }
   }
 
   return parts;

koladata/data_slice_repr_test.cc

@@ -1968,5 +1968,46 @@ TEST(DataSliceReprTest, SchemaToStr) {
               Eq("LIST[INT32]"));
 }
 
+TEST(DataSliceReprTest, TestDataItemStringRepresentation_SchemaName_SkipNone) {
+  {
+    // None values are skipped, but the schema values are not.
+    DataBagPtr bag = DataBag::EmptyMutable();
+    ASSERT_OK_AND_ASSIGN(
+        DataSlice entity_with_none,
+        EntityCreator::FromAttrs(
+            bag, {"a", "b"},
+            {test::DataItem(1), test::DataItem(std::nullopt, schema::kInt32)}));
+    EXPECT_THAT(DataSliceRepr(entity_with_none,
+                              {.show_databag_id = false, .show_schema = true}),
+                "DataItem(Entity(a=1), schema: ENTITY(a=INT32, b=INT32))");
+  }
+  {
+    // None values are not skipped when show_schema is false.
+    DataBagPtr bag = DataBag::EmptyMutable();
+    ASSERT_OK_AND_ASSIGN(
+        DataSlice entity_with_none,
+        EntityCreator::FromAttrs(
+            bag, {"a", "b"},
+            {test::DataItem(1), test::DataItem(std::nullopt, schema::kInt32)}));
+    EXPECT_THAT(
+        DataSliceRepr(entity_with_none,
+                      {.show_databag_id = false, .show_schema = false}),
+        "DataItem(Entity(a=1, b=None))");
+  }
+  {
+    // None values are not skipped for Objects.
+    DataBagPtr bag = DataBag::EmptyMutable();
+    ASSERT_OK_AND_ASSIGN(
+        DataSlice entity_with_none,
+        ObjectCreator::FromAttrs(
+            bag, {"a", "b"},
+            {test::DataItem(1), test::DataItem(std::nullopt, schema::kInt32)}));
+    EXPECT_THAT(
+        DataSliceRepr(entity_with_none,
+                      {.show_databag_id = false, .show_schema = true}),
+        "DataItem(Obj(a=1, b=None), schema: OBJECT)");
+  }
+}
+
 }  // namespace
 }  // namespace koladata