Simplify DataItem.__int__ and DataItem.__float__ by removing redundant type testing

apronchenkov · copybara-github · commit e4aef84d8ca7 · 2025-01-13T05:27:52.000-08:00
PyNumber_Long and PyNumber_Float already contain such checks and optimisations ( [src](https://github.com/python/cpython/blob/main/Objects/abstract.c#L1516-L1518), [src](https://github.com/python/cpython/blob/main/Objects/abstract.c#L1595-L1597)). PiperOrigin-RevId: 714930002 Change-Id: Ie2fdf540b40764af7550d65bf10e809067d30d01
diff --git a/py/koladata/types/data_item.cc b/py/koladata/types/data_item.cc
@@ -93,9 +93,6 @@ absl::Nullable<PyObject*> PyDataItem_int(PyObject* self) {
   if (py_obj == nullptr) {
     return nullptr;
   }
-  if (PyLong_Check(py_obj.get())) {
-    return py_obj.release();
-  }
   return PyNumber_Long(py_obj.get());
 }
 
@@ -113,9 +110,6 @@ absl::Nullable<PyObject*> PyDataItem_float(PyObject* self) {
   if (py_obj == nullptr) {
     return nullptr;
   }
-  if (PyFloat_Check(py_obj.get())) {
-    return py_obj.release();
-  }
   return PyNumber_Float(py_obj.get());
 }
 

Original file line number	Diff line number	Diff line change
`@@ -93,9 +93,6 @@ absl::Nullable<PyObject> PyDataItem_int(PyObject self) {`
`93`	`93`	`if (py_obj == nullptr) {`
`94`	`94`	`return nullptr;`
`95`	`95`	`}`
`96`		`- if (PyLong_Check(py_obj.get())) {`
`97`		`- return py_obj.release();`
`98`		`- }`
`99`	`96`	`return PyNumber_Long(py_obj.get());`
`100`	`97`	`}`
`101`	`98`
`@@ -113,9 +110,6 @@ absl::Nullable<PyObject> PyDataItem_float(PyObject self) {`
`113`	`110`	`if (py_obj == nullptr) {`
`114`	`111`	`return nullptr;`
`115`	`112`	`}`
`116`		`- if (PyFloat_Check(py_obj.get())) {`
`117`		`- return py_obj.release();`
`118`		`- }`
`119`	`113`	`return PyNumber_Float(py_obj.get());`
`120`	`114`	`}`
`121`	`115`