Skip to content

Commit 4c806b3

Browse files
authored
style: fix clang-format violations and re-enable clang-format check (#26)
Fix clang-format in build #2
1 parent 066f2a3 commit 4c806b3

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

.github/workflows/build_and_test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@ jobs:
6464
coverage report
6565
6666
- name: Check C++ test coverage
67-
if: false # TODO(#3): fix and then re-enable
6867
run: |
6968
# Run C++ coverage check
7069
echo -e "\n##### Running C++ coverage check #####"
@@ -78,7 +77,8 @@ jobs:
7877
--xml-pretty -o cxx-coverage.xml \
7978
--sort uncovered-number \
8079
--gcov-ignore-parse-errors negative_hits.warn \
81-
--gcov-ignore-parse-errors suspicious_hits.warn
80+
--gcov-ignore-parse-errors suspicious_hits.warn \
81+
--gcov-ignore-errors=no_working_dir_found
8282
8383
lint-code:
8484
runs-on: ubuntu-latest

src/ml_flashpoint/checkpoint_object_manager/buffer_object/test/buffer_object_test.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ TEST_F(BufferObjectTest, GetCapacityReturnsCorrectSize) {
225225
ASSERT_EQ(buffer.get_capacity(), expected_capacity);
226226

227227
// Test with the opening constructor.
228-
// The 'writer' scope ensures the file is closed before reopening.
228+
// The BufferObject constructor will create the file, and its destructor will close the file (without deleting)
229229
{
230230
BufferObject writer(test_path_ + "_new", 512);
231231
}
@@ -308,6 +308,7 @@ TEST_F(BufferObjectTest, CloseWithTruncateIgnoresTruncateOnReadOnlyFile) {
308308
const size_t truncate_to_size = 512;
309309

310310
// Setup: Create a file on disk with a known initial size.
311+
// The BufferObject constructor will create the file, and its destructor will close the file (without deleting)
311312
{
312313
BufferObject writable_buffer(test_path_, initial_size);
313314
}

0 commit comments

Comments
 (0)