Skip to content

Commit 6c16da3

Browse files
authored
Upgrade three-gpu-pathtracer, screenshots (#4686)
* bump versions * Update package lock * Small changes to renderer * Update screenshots * Remove screenshots * Update samples, config
1 parent 4daf1c7 commit 6c16da3

File tree

68 files changed

+31
-28
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

68 files changed

+31
-28
lines changed

package-lock.json

Lines changed: 20 additions & 21 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/render-fidelity-tools/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@
4444
"puppeteer": "^21.3.4",
4545
"rimraf": "^3.0.2",
4646
"three": "^0.160.0",
47-
"three-gpu-pathtracer": "^0.0.13",
47+
"three-gpu-pathtracer": "^0.0.20",
48+
"three-mesh-bvh": "^0.7.3",
4849
"yargs": "^17.7.2"
4950
},
5051
"devDependencies": {

packages/render-fidelity-tools/src/components/renderers/three-gpu-pathtracer-viewer.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
*/
1515

1616
import {PathTracingRenderer, PathTracingSceneGenerator, PhysicalPathTracingMaterial} from 'three-gpu-pathtracer';
17-
import {WebGLRenderer, MeshBasicMaterial, PerspectiveCamera, ACESFilmicToneMapping, sRGBEncoding, CustomBlending, MathUtils, Sphere, Box3, Object3D, Mesh, BufferAttribute, Group, DirectionalLight} from 'three';
17+
import {WebGLRenderer, MeshBasicMaterial, PerspectiveCamera, ACESFilmicToneMapping, CustomBlending, MathUtils, Sphere, Box3, Object3D, Mesh, BufferAttribute, Group, DirectionalLight} from 'three';
1818
import {FullScreenQuad} from 'three/examples/jsm/postprocessing/Pass';
1919
import {GLTFLoader} from 'three/examples/jsm/loaders/GLTFLoader';
2020
import {RGBELoader} from 'three/examples/jsm/loaders/RGBELoader';
@@ -75,10 +75,11 @@ export class ThreePathTracerViewer extends LitElement {
7575

7676
this[$renderer] = new WebGLRenderer({canvas: this[$canvas] || undefined});
7777
this[$renderer].toneMapping = ACESFilmicToneMapping;
78-
this[$renderer].outputEncoding = sRGBEncoding;
7978

8079
this[$pathtracer] = new PathTracingRenderer(this[$renderer]);
81-
this[$pathtracer].material = new PhysicalPathTracingMaterial();
80+
this[$pathtracer].material = new PhysicalPathTracingMaterial( {
81+
filterGlossyFactor: 0.5,
82+
} );
8283
this[$pathtracer].camera = this[$camera];
8384
this[$pathtracer].alpha = true;
8485

@@ -202,7 +203,7 @@ export class ThreePathTracerViewer extends LitElement {
202203

203204
this[$updateSize]();
204205

205-
const MAX_SAMPLES = 100;
206+
const MAX_SAMPLES = 64;
206207
let eventBroadcast = false;
207208
renderer.setAnimationLoop(() => {
208209
const camera = this[$camera];

packages/render-fidelity-tools/test/config.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,8 @@
294294
},
295295
"exclude": [
296296
"stellar",
297-
"vray"
297+
"vray",
298+
"three-gpu-pathtracer"
298299
]
299300
},
300301
{
@@ -607,7 +608,8 @@
607608
"y": -0.09
608609
},
609610
"exclude": [
610-
"vray"
611+
"vray",
612+
"three-gpu-pathtracer"
611613
]
612614
},
613615
{

0 commit comments

Comments
 (0)