rewind-version #1295
Annotations
10 warnings
|
build:
mug/src/test/java/com/google/mu/util/SubstringPatternTest.java#L2018
[InlineMeInliner] Migrate (via inlining) away from `Strings.repeat()`. NOTE: this is an unvalidated inlining! Reasoning: Java 11+ API only
|
|
build:
mug/src/test/java/com/google/mu/util/SubstringPatternTest.java#L1950
[InlineMeInliner] Migrate (via inlining) away from `Strings.repeat()`. NOTE: this is an unvalidated inlining! Reasoning: Java 11+ API only
|
|
build:
mug/src/test/java/com/google/mu/collect/MoreCollectionsTest.java#L193
[JdkObsolete] It is very rare for LinkedList to out-perform ArrayList or ArrayDeque. Avoid it unless you're willing to invest a lot of time into benchmarking. Caveat: LinkedList supports null elements, but ArrayDeque does not.
|
|
build:
mug/src/main/java/com/google/mu/util/graph/GraphWalker.java#L282
[UnusedVariable] The local variable 'n' is never read.
|
|
build:
mug/src/main/java/com/google/mu/util/concurrent/Utils.java#L22
[AnnotateFormatMethod] This method uses a pair of parameters as a format string and its arguments, but the enclosing method wasn't annotated. Doing so gives compile-time rather than run-time protection against malformed format strings.
|
|
build:
mug/src/main/java/com/google/mu/util/Ordinal.java#L91
[EnumOrdinal] You should almost never invoke the Enum.ordinal() method or depend on the enum values by index.
|
|
build:
mug/src/main/java/com/google/mu/util/Substring.java#L2806
[MissingOverride] isEmpty implements method in CharSequence; expected @OverRide
|
|
build:
mug/src/main/java/com/google/mu/util/BiOptional.java#L237
[AnnotateFormatMethod] This method uses a pair of parameters as a format string and its arguments, but the enclosing method wasn't annotated. Doing so gives compile-time rather than run-time protection against malformed format strings.
|
|
build:
mug/src/main/java/com/google/mu/util/stream/MoreStreams.java#L305
[StreamToIterable] Using stream::iterator creates a one-shot Iterable, which may cause surprising failures.
|
|
build:
mug/src/main/java/com/google/mu/collect/Chain.java#L134
[MissingOverride] getFirst implements method in List; expected @OverRide
|