call getLineNumber() only once per arg

Author: fluentfuture

mug-errorprone/src/main/java/com/google/mu/errorprone/SourceUtils.java

@@ -62,7 +62,12 @@ static ImmutableList<String> argsAsTexts(
       return ImmutableList.of();
     }
     LineMap lineMap = state.getPath().getCompilationUnit().getLineMap();
-    boolean inMultiline = inMultiline(position, args, lineMap);
+    long baseLine = lineMap.getLineNumber(position);
+    ImmutableList<Long> argLineNumbers =
+        args.stream()
+            .map(arg -> lineMap.getLineNumber(getStartPosition(arg)))
+            .collect(toImmutableList());
+    boolean isMultiline = argLineNumbers.stream().anyMatch(line -> line > baseLine);
     ImmutableList.Builder<String> builder = ImmutableList.builder();
     for (int i = 0; i < args.size(); i++) {
       ExpressionTree arg = args.get(i);
@@ -71,10 +76,7 @@ static ImmutableList<String> argsAsTexts(
         return ImmutableList.of();
       }
       int end =
-          inMultiline
-                  && (i == args.size() - 1
-                      || lineMap.getLineNumber(next)
-                          < lineMap.getLineNumber(getStartPosition(args.get(i + 1))))
+          isMultiline && (i == args.size() - 1 || argLineNumbers.get(i) < argLineNumbers.get(i + 1))
               ? locateLineEnd(state, next)
               : next;
       builder.add(state.getSourceCode().subSequence(position, end).toString());
@@ -83,13 +85,6 @@ static ImmutableList<String> argsAsTexts(
     return builder.build();
   }
 
-  private static boolean inMultiline(
-      int startPosition, List<? extends ExpressionTree> args, LineMap lineMap) {
-    long baseLine = lineMap.getLineNumber(startPosition);
-    return args.stream()
-        .anyMatch(arg -> lineMap.getLineNumber(getStartPosition(arg)) > baseLine);
-  }
-
   private static int locateLineEnd(VisitorState state, int pos) {
     CharSequence source = state.getSourceCode();
     int end = pos;