OboeTester: make Data Paths test match CTSV (#2217)

Remove the noise signal.
Use frequency 857 Hz.
Increase sine amplitude.
Raise threshold for phaseJitter.

Fixes #2216

Author: philburk

apps/OboeTester/app/src/main/cpp/analyzer/BaseSineAnalyzer.h

@@ -58,6 +58,12 @@ class BaseSineAnalyzer : public LoopbackProcessor {
         return mMagnitude;
     }
 
+    /**
+     * Set the amplitude of some white noise that can be added to the output signal.
+     * This can be used to try to defeat feedback suppression that may block pure sine waves.
+     * The default is zero because it can add phaseJitter and result in flaky tests.
+     * @param noiseAmplitude amplitude of white noise, default is 0.0
+     */
     void setNoiseAmplitude(double noiseAmplitude) {
         mNoiseAmplitude = noiseAmplitude;
     }
@@ -198,8 +204,9 @@ class BaseSineAnalyzer : public LoopbackProcessor {
     }
 
 protected:
-    // Try to get a prime period so the waveform plot changes every time.
-    static constexpr int32_t kTargetGlitchFrequency = 48000 / 113;
+    // Use a frequency that will not align with the common burst sizes.
+    // If it aligns then buffer reordering bugs could be masked.
+    static constexpr int32_t kTargetGlitchFrequency = 857; // Match CTS Verifier
 
     int32_t mSinePeriod = 1; // this will be set before use
     double  mInverseSinePeriod = 1.0;
@@ -209,7 +216,7 @@ class BaseSineAnalyzer : public LoopbackProcessor {
     // in a callback and the output frame count may advance ahead of the input, or visa versa.
     double  mInputPhase = 0.0;
     double  mOutputPhase = 0.0;
-    double  mOutputAmplitude = 0.75;
+    double  mOutputAmplitude = 0.90;
     // This is the phase offset between the mInputPhase sine wave and the recorded
     // signal at the tuned frequency.
     // If this jumps around then we are probably just hearing noise.
@@ -233,7 +240,8 @@ class BaseSineAnalyzer : public LoopbackProcessor {
 private:
     float   mTolerance = 0.10; // scaled from 0.0 to 1.0
 
-    float mNoiseAmplitude = 0.00; // Used to experiment with warbling caused by DRC.
+    // Default to zero because some phones have a high pass filter that make it too loud.
+    float mNoiseAmplitude = 0.0f;
     PseudoRandom  mWhiteNoise;
 };
 

apps/OboeTester/app/src/main/cpp/analyzer/DataPathAnalyzer.h

@@ -36,11 +36,6 @@
 class DataPathAnalyzer : public BaseSineAnalyzer {
 public:
 
-    DataPathAnalyzer() : BaseSineAnalyzer() {
-        // Add a little bit of noise to reduce blockage by speaker protection and DRC.
-        setNoiseAmplitude(0.02);
-    }
-
     double calculatePhaseError(double p1, double p2) {
         double diff = p1 - p2;
         // Wrap around the circle.

apps/OboeTester/app/src/main/java/com/mobileer/oboetester/TestDataPathsActivity.java

@@ -86,14 +86,9 @@ public class TestDataPathsActivity  extends BaseAutoGlitchActivity {
     public static final String KEY_USE_OUTPUT_DEVICES = "use_output_devices";
     public static final boolean VALUE_DEFAULT_USE_OUTPUT_DEVICES = true;
 
-
     public static final int DURATION_SECONDS = 4;
     private final static double MIN_REQUIRED_MAGNITUDE = 0.001;
-    private final static int MAX_SINE_FREQUENCY = 1000;
-    private final static int TYPICAL_SAMPLE_RATE = 48000;
-    private final static double FRAMES_PER_CYCLE = TYPICAL_SAMPLE_RATE / MAX_SINE_FREQUENCY;
-    private final static double PHASE_PER_BIN = 2.0 * Math.PI / FRAMES_PER_CYCLE;
-    private final static double MAX_ALLOWED_JITTER = 0.5 * PHASE_PER_BIN;
+    private final static double MAX_ALLOWED_JITTER = 0.1; // Matches CTS Verifier
     // This must match the value of kPhaseInvalid in BaseSineAnalyzer.h
     private final static double PHASE_INVALID = -999.0;
     private final static String MAGNITUDE_FORMAT = "%7.5f";