OboeTester: save all WAV files in Data Paths test (#2207)

Delete old files when the test starts.

Move message about saved files to Summary.

Author: philburk

apps/OboeTester/app/src/main/cpp/analyzer/BaseSineAnalyzer.h

@@ -165,7 +165,7 @@ class BaseSineAnalyzer : public LoopbackProcessor {
 
             ALOGD("%s(), phaseOffset = %f\n", __func__, mPhaseOffset);
             if (mPhaseOffset != kPhaseInvalid) {
-                // One pole averaging filter.
+                // One pole averaging filter for magnitude.
                 setMagnitude((mMagnitude * (1.0 - coefficient)) + (magnitude * coefficient));
             }
             resetAccumulator();

apps/OboeTester/app/src/main/java/com/mobileer/oboetester/AutomatedGlitchActivity.java

@@ -110,6 +110,8 @@ public void runTest() {
 
             compareFailedTestsWithNearestPassingTest();
 
+            reportSavedWaveFiles();
+
         } catch (InterruptedException e) {
             compareFailedTestsWithNearestPassingTest();
 

apps/OboeTester/app/src/main/java/com/mobileer/oboetester/BaseAutoGlitchActivity.java

@@ -273,6 +273,10 @@ protected TestResult testCurrentConfigurations() throws InterruptedException {
         }
 
         log("========================== #" + getTestCount());
+        if (getTestCount() == 1) {
+            deleteOldWaveFiles();
+        }
+
         int result = 0;
         StreamConfiguration requestedInConfig = mAudioInputTester.requestedConfiguration;
         StreamConfiguration requestedOutConfig = mAudioOutTester.requestedConfiguration;
@@ -385,13 +389,13 @@ protected TestResult testCurrentConfigurations() throws InterruptedException {
                 appendFailedSummary("  " + getConfigText(actualInConfig) + "\n");
                 appendFailedSummary("  " + getConfigText(actualOutConfig) + "\n");
                 appendFailedSummary("    " + resultText + "\n");
-                saveRecordingAsWave();
                 mAutomatedTestRunner.incrementFailCount();
                 result = TEST_RESULT_FAILED;
             } else {
                 mAutomatedTestRunner.incrementPassCount();
                 result = TEST_RESULT_PASSED;
             }
+            saveRecordingAsWave(); // Save recording for both pass and fail results.
         }
         mAutomatedTestRunner.flushLog();
 
@@ -434,14 +438,45 @@ void testPerformancePaths() throws InterruptedException {
         requestedOutConfig.setMMap(false);
     }
 
+    File getRecordingDir() {
+        return getExternalFilesDir(Environment.DIRECTORY_MUSIC);
+    }
+
+    void reportSavedWaveFiles() {
+        logAnalysis("\n --------\n"
+                + "Audio for each test saved in:\n  "
+                + getRecordingDir().getAbsolutePath()
+                + "/glitch_{###}.wav\n");
+    }
+
     private void saveRecordingAsWave() {
-        File recordingDir = getExternalFilesDir(Environment.DIRECTORY_MUSIC);
-        File waveFile = new File(recordingDir, String.format("glitch_%03d.wav", getTestCount()));
+        File waveFile = new File(getRecordingDir(),
+                String.format("glitch_%03d.wav", getTestCount()));
         int saveResult = saveWaveFile(waveFile.getAbsolutePath());
-        if (saveResult > 0) {
-            appendFailedSummary("Saved in " + waveFile.getAbsolutePath() + "\n");
-        } else {
-            appendFailedSummary("saveWaveFile() returned " + saveResult + "\n");
+        if (saveResult <= 0) {
+            appendSummary("ERROR: saving "
+                    + waveFile.getAbsolutePath()
+                    + " returned " + saveResult + "\n");
+        }
+    }
+
+    /**
+     * Delete all the previously saved WAV files so the user does not
+     * debug obsolete data.
+     */
+    private void deleteOldWaveFiles() {
+        File recordingDir = getRecordingDir();
+        if (recordingDir.exists()) {
+            File[] files = recordingDir.listFiles();
+            if (files != null) {
+                for (File file : files) {
+                    if (file.isFile()) {
+                        if (!file.delete()) {
+                            appendFailedSummary("Failed to delete file: " + file.getAbsolutePath());
+                        }
+                    }
+                }
+            }
         }
     }
 

apps/OboeTester/app/src/main/java/com/mobileer/oboetester/TestDataPathsActivity.java

@@ -873,6 +873,8 @@ public void runTest() {
 
             compareFailedTestsWithNearestPassingTest();
 
+            reportSavedWaveFiles();
+
         } catch (InterruptedException e) {
             compareFailedTestsWithNearestPassingTest();
         } catch (Exception e) {