Skip to content

Commit 2fc7e2c

Browse files
committed
perfetto: expose android_extensions protos as a public Bazel proto group
The per-directory proto targets generated for protos/third_party/android are private (PERFETTO_CONFIG.proto_library_visibility), so external Bazel consumers have no target they are allowed to depend on. Add an android_extensions entry to proto_groups so gen_bazel emits a grouped android_extensions_proto target gated by the embedder-controlled PERFETTO_CONFIG.public_visibility allowlist, following the existing chromium precedent.
1 parent ad11a43 commit 2fc7e2c

2 files changed

Lines changed: 106 additions & 0 deletions

File tree

BUILD

Lines changed: 100 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7042,6 +7042,106 @@ perfetto_dart_proto_library(
70427042
],
70437043
)
70447044

7045+
# GN target: [//protos/third_party/android:android_extensions_source_set]
7046+
perfetto_proto_library(
7047+
name = "android_extensions_proto",
7048+
visibility = PERFETTO_CONFIG.public_visibility,
7049+
deps = [
7050+
":protos_perfetto_common_protos",
7051+
":protos_perfetto_common_semantic_type_protos",
7052+
":protos_perfetto_config_android_protos",
7053+
":protos_perfetto_config_ftrace_protos",
7054+
":protos_perfetto_config_gpu_protos",
7055+
":protos_perfetto_config_inode_file_protos",
7056+
":protos_perfetto_config_interceptors_protos",
7057+
":protos_perfetto_config_linux_protos",
7058+
":protos_perfetto_config_power_protos",
7059+
":protos_perfetto_config_priority_boost_protos",
7060+
":protos_perfetto_config_process_stats_protos",
7061+
":protos_perfetto_config_profiling_protos",
7062+
":protos_perfetto_config_protos",
7063+
":protos_perfetto_config_protovm_protos",
7064+
":protos_perfetto_config_qnx_protos",
7065+
":protos_perfetto_config_statsd_protos",
7066+
":protos_perfetto_config_sys_stats_protos",
7067+
":protos_perfetto_config_system_info_protos",
7068+
":protos_perfetto_config_track_event_protos",
7069+
":protos_perfetto_protovm_protos",
7070+
":protos_perfetto_trace_android_protos",
7071+
":protos_perfetto_trace_chrome_protos",
7072+
":protos_perfetto_trace_etw_protos",
7073+
":protos_perfetto_trace_filesystem_protos",
7074+
":protos_perfetto_trace_ftrace_protos",
7075+
":protos_perfetto_trace_generic_kernel_protos",
7076+
":protos_perfetto_trace_gpu_protos",
7077+
":protos_perfetto_trace_interned_data_protos",
7078+
":protos_perfetto_trace_linux_protos",
7079+
":protos_perfetto_trace_minimal_protos",
7080+
":protos_perfetto_trace_non_minimal_protos",
7081+
":protos_perfetto_trace_perfetto_protos",
7082+
":protos_perfetto_trace_power_protos",
7083+
":protos_perfetto_trace_profiling_protos",
7084+
":protos_perfetto_trace_ps_protos",
7085+
":protos_perfetto_trace_statsd_protos",
7086+
":protos_perfetto_trace_sys_stats_protos",
7087+
":protos_perfetto_trace_system_info_protos",
7088+
":protos_perfetto_trace_track_event_protos",
7089+
":protos_perfetto_trace_translation_protos",
7090+
":protos_third_party_android_android_extensions_protos",
7091+
":protos_third_party_android_frameworks_base_proto_tracing_frameworks_base_interned_data_protos",
7092+
":protos_third_party_android_frameworks_base_proto_tracing_frameworks_base_trace_packet_protos",
7093+
":protos_third_party_android_frameworks_base_proto_tracing_frameworks_base_track_event_protos",
7094+
":protos_third_party_android_frameworks_native_tracing_frameworks_native_track_event_protos",
7095+
":protos_third_party_android_frameworks_native_tracing_winscope_winscope_extensions_protos",
7096+
":protos_third_party_android_frameworks_native_tracing_winscope_winscope_regular_protos",
7097+
],
7098+
)
7099+
7100+
# GN target: [//protos/third_party/android:android_extensions_source_set]
7101+
perfetto_cc_proto_library(
7102+
name = "android_extensions_cc_proto",
7103+
visibility = PERFETTO_CONFIG.public_visibility,
7104+
deps = [
7105+
":android_extensions_proto",
7106+
],
7107+
)
7108+
7109+
# GN target: [//protos/third_party/android:android_extensions_source_set]
7110+
perfetto_java_proto_library(
7111+
name = "android_extensions_java_proto",
7112+
visibility = PERFETTO_CONFIG.public_visibility,
7113+
deps = [
7114+
":android_extensions_proto",
7115+
],
7116+
)
7117+
7118+
# GN target: [//protos/third_party/android:android_extensions_source_set]
7119+
perfetto_java_lite_proto_library(
7120+
name = "android_extensions_java_proto_lite",
7121+
visibility = PERFETTO_CONFIG.public_visibility,
7122+
deps = [
7123+
":android_extensions_proto",
7124+
],
7125+
)
7126+
7127+
# GN target: [//protos/third_party/android:android_extensions_source_set]
7128+
perfetto_py_proto_library(
7129+
name = "android_extensions_py_pb2",
7130+
visibility = PERFETTO_CONFIG.public_visibility,
7131+
deps = [
7132+
":android_extensions_proto",
7133+
],
7134+
)
7135+
7136+
# GN target: [//protos/third_party/android:android_extensions_source_set]
7137+
perfetto_dart_proto_library(
7138+
name = "android_extensions_dart_proto",
7139+
visibility = PERFETTO_CONFIG.public_visibility,
7140+
deps = [
7141+
":android_extensions_proto",
7142+
],
7143+
)
7144+
70457145
# GN target: [//protos/perfetto/metrics/chrome:source_set]
70467146
perfetto_proto_library(
70477147
name = "chrome_metrics_proto",

tools/gen_bazel

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,12 @@ proto_groups = {
153153
'sources': ['//protos/third_party/chromium:source_set',],
154154
'visibility': ALLOWLIST_PUBLIC_VISIBILITY,
155155
},
156+
'android_extensions': {
157+
'sources': [
158+
'//protos/third_party/android:android_extensions_source_set',
159+
],
160+
'visibility': ALLOWLIST_PUBLIC_VISIBILITY,
161+
},
156162
'chrome_metrics': {
157163
'sources': ['//protos/perfetto/metrics/chrome:source_set',],
158164
'visibility': ALLOWLIST_PUBLIC_VISIBILITY,

0 commit comments

Comments
 (0)