Skip to content

Commit 7dc843e

Browse files
author
David Bienvenu
committed
Add stat for disk io event without event name
1 parent 992d6df commit 7dc843e

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

src/trace_processor/importers/etw/disk_io_tracker.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,14 @@
1818

1919
#include <optional>
2020

21-
#include "perfetto/base/logging.h"
2221
#include "perfetto/protozero/field.h"
2322
#include "protos/perfetto/trace/etw/etw.pbzero.h"
2423
#include "protos/perfetto/trace/etw/etw_event.pbzero.h"
2524
#include "src/trace_processor/importers/common/args_tracker.h"
2625
#include "src/trace_processor/importers/common/process_tracker.h"
2726
#include "src/trace_processor/importers/common/slice_tracker.h"
2827
#include "src/trace_processor/importers/common/track_compressor.h"
28+
#include "src/trace_processor/importers/common/stats_tracker.h"
2929

3030
namespace perfetto::trace_processor {
3131

@@ -149,7 +149,7 @@ void DiskIoTracker::ParseDiskIo(int64_t timestamp,
149149

150150
const char* event_type = GetEventTypeString(opcode);
151151
if (!event_type) {
152-
PERFETTO_DLOG("Unable to convert disk io opcode %d to event_type", opcode);
152+
context_->stats_tracker->IncrementStats(stats::missing_disk_io_event_name);
153153
return;
154154
}
155155

src/trace_processor/storage/stats.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,7 @@ namespace perfetto::trace_processor::stats {
138138
F(app_wakelock_unknown_id, kSingle, kError, kAnalysis, Scope::kMachineAndTrace, \
139139
"Interning ID not found. Should never happen."), \
140140
F(meminfo_unknown_keys, kSingle, kError, kAnalysis, Scope::kMachineAndTrace, ""), \
141+
F(missing_disk_io_event_name, kSingle, kError, kAnalysis, Scope::kMachineAndTrace, ""), \
141142
F(mismatched_sched_switch_tids, kSingle, kError, kAnalysis, Scope::kMachineAndTrace, ""), \
142143
F(mm_unknown_type, kSingle, kError, kAnalysis, Scope::kMachineAndTrace, ""), \
143144
F(parse_trace_duration_ns, kSingle, kInfo, kAnalysis, Scope::kGlobal, ""), \

0 commit comments

Comments
 (0)