[DNS] tp: speed up JSON tokenization/parsing by 4.5x

Switch away from jsoncpp which has atrocious perf for parsing in favour
of writing our own parser. Moreover, remove some uses of a poor quality
json value fetch function in favour of our own.

test

Fix

fix

fix

Author: LalitMaganti

include/perfetto/ext/base/circular_queue.h

@@ -25,6 +25,7 @@
 
 #include "perfetto/base/logging.h"
 #include "perfetto/ext/base/utils.h"
+#include "perfetto/public/compiler.h"
 
 namespace perfetto {
 namespace base {
@@ -308,7 +309,7 @@ class CircularQueue {
     entries_ = std::move(new_vec);
   }
 
-  inline T* Get(uint64_t pos) {
+  PERFETTO_ALWAYS_INLINE inline T* Get(uint64_t pos) {
     PERFETTO_DCHECK(pos >= begin_ && pos < end_);
     PERFETTO_DCHECK((capacity_ & (capacity_ - 1)) == 0);  // Must be a pow2.
     auto index = static_cast<size_t>(pos & (capacity_ - 1));

src/trace_processor/importers/common/parser_types.h

@@ -20,13 +20,14 @@
 #include <array>
 #include <cstdint>
 #include <functional>
+#include <limits>
 #include <optional>
-#include <string>
 #include <utility>
 #include <variant>
 
 #include "perfetto/trace_processor/ref_counted.h"
 #include "perfetto/trace_processor/trace_blob_view.h"
+#include "src/trace_processor/containers/interval_tree.h"
 #include "src/trace_processor/containers/string_pool.h"
 #include "src/trace_processor/importers/proto/packet_sequence_state_generation.h"
 
@@ -57,16 +58,79 @@ struct alignas(8) InlineSchedWaking {
 static_assert(sizeof(InlineSchedWaking) == 16);
 
 struct alignas(8) JsonEvent {
-  struct Begin {};
-  struct End {};
-  struct Scoped {
-    int64_t dur;
+  using StrOrUint64 = std::variant<std::monostate, StringPool::Id, uint64_t>;
+
+  int64_t dur = std::numeric_limits<int64_t>::max();
+
+  uint32_t pid = 0;
+  uint32_t tid = 0;
+
+  StringPool::Id name = StringPool::Id::Null();
+  StringPool::Id cat = StringPool::Id::Null();
+
+  union IdStrOrUint64 {
+    StringPool::Id id_str;
+    uint64_t id_uint64;
   };
-  struct Other {};
-  using Type = std::variant<Begin, End, Scoped, Other>;
+  IdStrOrUint64 id;
+  IdStrOrUint64 bind_id;
+
+  int64_t tts = std::numeric_limits<int64_t>::max();
+  int64_t tdur = std::numeric_limits<int64_t>::max();
+
+  char phase = '\0';
 
-  std::string value;
-  Type type;
+  uint64_t flow_in : 1;
+  uint64_t flow_out : 1;
+
+  uint64_t pid_is_string_id : 1;
+  uint64_t tid_is_string_id : 1;
+
+  uint64_t bind_enclosing_slice : 1;
+
+  enum class IdType : uint64_t {
+    kNone = 0,
+    kString = 1,
+    kUint64 = 2,
+  };
+  IdType id_type : 2;
+  IdType bind_id_type : 2;
+
+  enum class Scope : uint64_t {
+    kNone = 0,
+    kGlobal = 1,
+    kProcess = 2,
+    kThread = 3,
+  };
+  Scope scope : 2;
+
+  JsonEvent()
+      : flow_in(false),
+        flow_out(false),
+        pid_is_string_id(false),
+        tid_is_string_id(false),
+        bind_enclosing_slice(false),
+        id_type(IdType::kNone),
+        bind_id_type(IdType::kNone),
+        scope(Scope::kNone) {}
+
+  // json::JsonValue2 dur;
+  // uint32_t pid;
+  // uint32_t tid;
+  // json::JsonValue2 id;
+  // json::JsonValue2 cat;
+  // json::JsonValue2 name;
+
+  // struct Begin {};
+  // struct End {};
+  // struct Scoped {
+  //   int64_t dur;
+  // };
+  // struct Other {};
+  // using Type = std::variant<Begin, End, Scoped, Other>;
+
+  // std::string value;
+  // Type type;
 };
 static_assert(sizeof(JsonEvent) % 8 == 0);
 

src/trace_processor/importers/common/trace_parser.h

@@ -19,6 +19,7 @@
 
 #include <cstdint>
 #include <string>
+#include "src/trace_processor/importers/common/parser_types.h"
 
 namespace perfetto::trace_processor {
 namespace perf_importer {
@@ -63,7 +64,7 @@ class ProtoTraceParser {
 class JsonTraceParser {
  public:
   virtual ~JsonTraceParser();
-  virtual void ParseJsonPacket(int64_t, std::string) = 0;
+  virtual void ParseJsonPacket(int64_t, JsonEvent) = 0;
   virtual void ParseSystraceLine(int64_t, SystraceLine) = 0;
   virtual void ParseLegacyV8ProfileEvent(int64_t, LegacyV8CpuProfileEvent) = 0;
 };