Skip to content

Commit 53a7061

Browse files
ianswettcopybara-github
authored andcommitted
Deprecate gfe2_reloadable_flag_quic_allow_client_enabled_bbr_v2.
PiperOrigin-RevId: 863046303
1 parent e3341c7 commit 53a7061

File tree

3 files changed

+1
-8
lines changed

3 files changed

+1
-8
lines changed

quiche/common/quiche_feature_flags_list.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ QUICHE_FLAG(bool, quiche_reloadable_flag_enable_h3_origin_frame, false, true, "I
1212
QUICHE_FLAG(bool, quiche_reloadable_flag_http2_avoid_decompose_representation, false, false, "If true, HPACK encoding will use a different iteration method that avoids unnecessary copies and string splitting.")
1313
QUICHE_FLAG(bool, quiche_reloadable_flag_quic_act_upon_invalid_header, true, true, "If true, reject or send error response code upon receiving invalid request or response headers.")
1414
QUICHE_FLAG(bool, quiche_reloadable_flag_quic_add_stream_info_to_idle_close_detail, false, true, "If true, include stream information in idle timeout connection close detail.")
15-
QUICHE_FLAG(bool, quiche_reloadable_flag_quic_allow_client_enabled_bbr_v2, true, true, "If true, allow client to enable BBRv2 on server via connection option 'B2ON'.")
1615
QUICHE_FLAG(bool, quiche_reloadable_flag_quic_bandwidth_sampler_guard_rtt_subtraction, false, false, "When true, BandwidthSampler::OnPacketAcknowledgedInner() will return early rather than compute a negative RTT.")
1716
QUICHE_FLAG(bool, quiche_reloadable_flag_quic_bbr2_extra_acked_window, false, true, "When true, the BBR4 copt sets the extra_acked window to 20 RTTs and BBR5 sets it to 40 RTTs.")
1817
QUICHE_FLAG(bool, quiche_reloadable_flag_quic_bbr_always_exit_startup_on_loss, false, false, "Lets BBRv1 exit STARTUP if a large number of packets was lost even if there is no non-app-limited samples. Similar to applying connection option B1AL to all connection.")

quiche/quic/core/http/end_to_end_test.cc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -209,10 +209,6 @@ std::vector<TestParams> GetTestParams(
209209
std::vector<int> connection_id_lengths{-1, kLongConnectionIdLength};
210210
for (auto connection_id_length : connection_id_lengths) {
211211
for (const QuicTag congestion_control_tag : {kTBBR, kQBIC, kB2ON}) {
212-
if (!GetQuicReloadableFlag(quic_allow_client_enabled_bbr_v2) &&
213-
congestion_control_tag == kB2ON) {
214-
continue;
215-
}
216212
for (const ParsedQuicVersion& version : CurrentSupportedVersions()) {
217213
if (connection_id_length == -1 || version.IsIetfQuic()) {
218214
params.push_back(TestParams(version, congestion_control_tag,

quiche/quic/core/quic_sent_packet_manager.cc

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -153,9 +153,7 @@ void QuicSentPacketManager::SetFromConfig(const QuicConfig& config) {
153153
if (config.HasClientRequestedIndependentOption(kTBBR, perspective)) {
154154
SetSendAlgorithm(kBBR);
155155
}
156-
if (GetQuicReloadableFlag(quic_allow_client_enabled_bbr_v2) &&
157-
config.HasClientRequestedIndependentOption(kB2ON, perspective)) {
158-
QUIC_RELOADABLE_FLAG_COUNT(quic_allow_client_enabled_bbr_v2);
156+
if (config.HasClientRequestedIndependentOption(kB2ON, perspective)) {
159157
SetSendAlgorithm(kBBRv2);
160158
}
161159

0 commit comments

Comments
 (0)