Support for Multiple suppression files in TSAN

[ApoorvaShetty16]

I have an application that now requires 2 suppression files to be considered. I don't see any documentation on if this is supported and how we could use it.

export TSAN_OPTIONS="suppressions=$RUNFILES_DIR/common/support/sanitizer/tsan.supp:${RUNFILES_DIR}/specific/support/tsan.supp"

This does not seem to be working.

Can someone please help ?

[ramosian-glider]

Using suppressions is considered the last resort. TSan does not support more than one suppression file, as this is usually unnecessary.

You may consider one of the following options:

1. Link one of your suppressions file directly into the binary, like Chromium does: https://source.chromium.org/chromium/chromium/src/+/main:build/sanitizers/sanitizer_options.cc;l=105?q=kTsanDefaultSuppressions&ss=chromium
2. Make your build system concatenate your suppressions into a single file for you.

But overall there shouldn't be too many suppressions, and the best solution is to always fix the data races.

Adding a label so that we reflect this in the documentation.