Skip to content

Commit a3e8a68

Browse files
authored
Merge pull request #12851 from google/enhancement/12598-standardize-navigation-icons
Enhancement/12598 Standardize navigation icons
2 parents 9041818 + 73bb58e commit a3e8a68

7 files changed

Lines changed: 55 additions & 29 deletions

File tree

assets/js/components/DashboardNavigation/Navigation/index.js

Lines changed: 38 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -231,30 +231,62 @@ export default function Navigation() {
231231
// Handle scroll events to update sticky state and selected chip.
232232
useEvent( 'scroll', throttledOnScroll );
233233

234+
const navigationChipIconSize = 20;
235+
234236
const chips = {
235237
[ ANCHOR_ID_KEY_METRICS ]: {
236238
label: __( 'Key metrics', 'google-site-kit' ),
237-
icon: <NavKeyMetricsIcon width="18" height="16" />,
239+
icon: (
240+
<NavKeyMetricsIcon
241+
width={ navigationChipIconSize }
242+
height={ navigationChipIconSize }
243+
/>
244+
),
238245
},
239246
[ ANCHOR_ID_TRAFFIC ]: {
240247
label: __( 'Traffic', 'google-site-kit' ),
241-
icon: <NavTrafficIcon width="18" height="16" />,
248+
icon: (
249+
<NavTrafficIcon
250+
width={ navigationChipIconSize }
251+
height={ navigationChipIconSize }
252+
/>
253+
),
242254
},
243255
[ ANCHOR_ID_SITE_GOALS ]: {
244256
label: __( 'Site goals', 'google-site-kit' ),
245-
icon: <NavSiteGoalsIcon width="17" height="17" />,
257+
icon: (
258+
<NavSiteGoalsIcon
259+
width={ navigationChipIconSize }
260+
height={ navigationChipIconSize }
261+
/>
262+
),
246263
},
247264
[ ANCHOR_ID_CONTENT ]: {
248265
label: __( 'Content', 'google-site-kit' ),
249-
icon: <NavContentIcon width="18" height="18" />,
266+
icon: (
267+
<NavContentIcon
268+
width={ navigationChipIconSize }
269+
height={ navigationChipIconSize }
270+
/>
271+
),
250272
},
251273
[ ANCHOR_ID_SPEED ]: {
252274
label: __( 'Speed', 'google-site-kit' ),
253-
icon: <NavSpeedIcon width="20" height="16" />,
275+
icon: (
276+
<NavSpeedIcon
277+
width={ navigationChipIconSize }
278+
height={ navigationChipIconSize }
279+
/>
280+
),
254281
},
255282
[ ANCHOR_ID_MONETIZATION ]: {
256283
label: __( 'Monetization', 'google-site-kit' ),
257-
icon: <NavMonetizationIcon width="18" height="16" />,
284+
icon: (
285+
<NavMonetizationIcon
286+
width={ navigationChipIconSize }
287+
height={ navigationChipIconSize }
288+
/>
289+
),
258290
},
259291
};
260292

Lines changed: 2 additions & 2 deletions
Loading
Lines changed: 5 additions & 5 deletions
Loading
Lines changed: 2 additions & 2 deletions
Loading
Lines changed: 4 additions & 9 deletions
Loading
Lines changed: 2 additions & 3 deletions
Loading
Lines changed: 2 additions & 2 deletions
Loading

0 commit comments

Comments
 (0)