You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Update comments for clarity in Sign_In_With_Google tests.
Refine comments in the Sign_In_With_GoogleTest and Web_TagTest classes
to enhance readability and understanding of the test logic.
This improves maintainability and helps future developers grasp the
purpose of the tests more easily.
$this->assertStringContainsString( "response.integration='connect_existing_profile'", $output, 'Rendered script should set the connect_existing_profile integration when the flag is on.' );
245
245
$this->assertStringContainsString( 'response.connect_nonce=', $output, 'Rendered script should include the connect nonce assignment when the flag is on.' );
246
246
$this->assertStringContainsString( wp_create_nonce( Authenticator::CONNECT_NONCE_ACTION ), $output, 'Rendered nonce should match wp_create_nonce for CONNECT_NONCE_ACTION.' );
247
247
248
-
// Toggle the flag off on the same instance to guard against a vacuous
249
-
// pass if the marker strings ever change. The positive phase above
250
-
// fails first when that happens, signalling the negative assertions
251
-
// below need updating too.
248
+
// Toggling the flag off on the same instance guards against a vacuous pass if the marker
249
+
// strings ever change. The positive phase above fails first when that happens, signalling
250
+
// that the negative assertions below need updating too.
$this->assertStringNotContainsString( "response.integration='connect_existing_profile'", $output, 'Rendered script should not include the connect integration when the flag is off.' );
@@ -263,9 +262,8 @@ public function test_render_tag__forces_button_render_loop_on_connect_flow_even_
263
262
264
263
$output = $this->capture_render_tag_output();
265
264
266
-
// Logged-in users normally skip the button render loop; the connect
267
-
// flow flips that gate so the placeholder div on the profile page
268
-
// can still be wired up.
265
+
// Logged-in users normally skip the button render loop. The connect flow flips that gate
266
+
// so the placeholder div on the profile page can still be wired up.
269
267
$this->assertStringContainsString( 'google.accounts.id.renderButton', $output, 'Connect flow should force the button render loop even when the user is logged in.' );
270
268
$this->assertStringContainsString( 'googlesitekit-sign-in-with-google__frontend-output-button', $output, 'Render loop should target the SiwG placeholder class.' );
0 commit comments