Skip to content

Commit ca2f64c

Browse files
authored
Merge pull request #12116 from google/infra/12115-e2e-admin-tracking
Remove test for module pages.
2 parents bd6e961 + d3c561e commit ca2f64c

2 files changed

Lines changed: 1 addition & 28 deletions

File tree

tests/e2e/config/bootstrap.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ jest.setTimeout( PUPPETEER_TIMEOUT || 100000 );
203203
// Set default timeout for Puppeteer waits. (Default: 30 sec)
204204
page.setDefaultTimeout( 5_000 );
205205
// Set default timeout for individual expect-puppeteer assertions. (Default: 1000)
206-
setDefaultOptions( { timeout: EXPECT_PUPPETEER_TIMEOUT || 1000 } );
206+
setDefaultOptions( { timeout: EXPECT_PUPPETEER_TIMEOUT || 2_000 } );
207207

208208
// Add custom matchers specific to Site Kit.
209209
expect.extend( customMatchers );

tests/e2e/specs/admin-tracking.test.js

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -282,33 +282,6 @@ describe( 'admin tracking', () => {
282282
await expect( page ).toHaveTracking();
283283
} );
284284
} );
285-
286-
describe( 'module pages', () => {
287-
it( 'does not load tracking if not opted-in', async () => {
288-
await setupSiteKit();
289-
await visitAdminPage(
290-
'admin.php',
291-
'page=googlesitekit-module-search-console'
292-
);
293-
294-
await expect( page ).not.toHaveTracking();
295-
} );
296-
297-
it( 'loads tracking when opted-in', async () => {
298-
await visitAdminPage(
299-
'admin.php',
300-
'page=googlesitekit-splash'
301-
);
302-
await toggleOptIn();
303-
await setupSiteKit();
304-
await visitAdminPage(
305-
'admin.php',
306-
'page=googlesitekit-module-search-console'
307-
);
308-
309-
await expect( page ).toHaveTracking();
310-
} );
311-
} );
312285
} );
313286

314287
describe( 'initialization on load for non-Site Kit screens', () => {

0 commit comments

Comments
 (0)