Skip to content

Commit ceb4139

Browse files
committed
Register advanced data breakdowns datapoints for site goals feature.
This change updates the Analytics_4 module to register the advanced data breakdowns settings and save settings datapoints when the siteGoals feature flag is enabled. This ensures that the necessary functionality is available for users utilizing advanced data breakdowns.
1 parent 97081ee commit ceb4139

2 files changed

Lines changed: 22 additions & 2 deletions

File tree

includes/Modules/Analytics_4.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -988,13 +988,13 @@ protected function get_datapoint_definitions() {
988988
);
989989

990990
if ( Feature_Flags::enabled( 'siteGoals' ) ) {
991-
$datapoints['GET:advanced-data-breakdowns-settings'] = new Get_Advanced_Data_Breakdowns_Settings(
991+
$this->datapoints['GET:advanced-data-breakdowns-settings'] = new Get_Advanced_Data_Breakdowns_Settings(
992992
array(
993993
'advanced_data_breakdowns_settings' => $this->advanced_data_breakdowns_settings,
994994
'service' => '',
995995
)
996996
);
997-
$datapoints['POST:save-advanced-data-breakdowns-settings'] = new Save_Advanced_Data_Breakdowns_Settings(
997+
$this->datapoints['POST:save-advanced-data-breakdowns-settings'] = new Save_Advanced_Data_Breakdowns_Settings(
998998
array(
999999
'advanced_data_breakdowns_settings' => $this->advanced_data_breakdowns_settings,
10001000
'service' => '',

tests/phpunit/integration/Modules/Analytics_4Test.php

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1772,6 +1772,26 @@ public function test_get_datapoints__conversionReporting() {
17721772
'Analytics 4 module should expose the expected datapoints with conversion reporting'
17731773
);
17741774
}
1775+
1776+
public function test_get_datapoints__registers_advanced_data_breakdowns_when_site_goals_enabled() {
1777+
$this->enable_feature( 'siteGoals' );
1778+
1779+
$analytics = new Analytics_4( $this->context, $this->options, $this->user_options, $this->authentication );
1780+
1781+
$datapoints = $analytics->get_datapoints();
1782+
1783+
$this->assertContains(
1784+
'advanced-data-breakdowns-settings',
1785+
$datapoints,
1786+
'Enabling the siteGoals feature flag should register the advanced data breakdowns datapoint.'
1787+
);
1788+
$this->assertContains(
1789+
'save-advanced-data-breakdowns-settings',
1790+
$datapoints,
1791+
'Enabling the siteGoals feature flag should register the save advanced data breakdowns datapoint.'
1792+
);
1793+
}
1794+
17751795
public function test_get_debug_fields() {
17761796
$this->analytics->register();
17771797

0 commit comments

Comments
 (0)