Address CR feedback.

ankitrox · ankitrox · commit f0b27e439c41 · 2026-05-06T13:18:23.000+05:30
diff --git a/assets/js/components/KeyMetrics/MetricsSelectionPanel/__snapshots__/index.test.js.snap b/assets/js/components/KeyMetrics/MetricsSelectionPanel/__snapshots__/index.test.js.snap
@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`MetricsSelectionPanel Header should match snapshot with setupFlowRefresh enabled 1`] = `
+exports[`MetricsSelectionPanel Header should render correctly 1`] = `
 <body
   class="googlesitekit-side-sheet-scroll-lock"
 >
@@ -38,7 +38,7 @@ exports[`MetricsSelectionPanel Header should match snapshot with setupFlowRefres
         <p
           class="googlesitekit-typography googlesitekit-typography--body googlesitekit-typography--medium"
         >
-          Edit your personalized goals in 
+          Edit your personalized goals or deactivate this widget in 
           <button
             class="googlesitekit-cta-link googlesitekit-cta-link--secondary"
           >
@@ -301,7 +301,7 @@ exports[`MetricsSelectionPanel Header should match snapshot with setupFlowRefres
 </body>
 `;
 
-exports[`MetricsSelectionPanel Header should render correctly 1`] = `
+exports[`MetricsSelectionPanel Header should render correctly with the \`setupFlowRefresh\` feature flag enabled 1`] = `
 <body
   class="googlesitekit-side-sheet-scroll-lock"
 >
@@ -339,7 +339,7 @@ exports[`MetricsSelectionPanel Header should render correctly 1`] = `
         <p
           class="googlesitekit-typography googlesitekit-typography--body googlesitekit-typography--medium"
         >
-          Edit your personalized goals or deactivate this widget in 
+          Edit your personalized goals in 
           <button
             class="googlesitekit-cta-link googlesitekit-cta-link--secondary"
           >
diff --git a/assets/js/components/KeyMetrics/MetricsSelectionPanel/index.test.js b/assets/js/components/KeyMetrics/MetricsSelectionPanel/index.test.js
@@ -58,10 +58,7 @@ import {
 	KEY_METRICS_SELECTION_FORM,
 	KEY_METRICS_SELECTION_PANEL_OPENED_KEY,
 } from '@/js/components/KeyMetrics/constants';
-import {
-	VIEW_CONTEXT_MAIN_DASHBOARD,
-	VIEW_CONTEXT_MAIN_DASHBOARD_VIEW_ONLY,
-} from '@/js/googlesitekit/constants';
+import { VIEW_CONTEXT_MAIN_DASHBOARD_VIEW_ONLY } from '@/js/googlesitekit/constants';
 import { provideKeyMetricsWidgetRegistrations } from '@/js/components/KeyMetrics/test-utils';
 import * as analytics4Fixtures from '@/js/modules/analytics-4/datastore/__fixtures__';
 import {
@@ -160,7 +157,7 @@ describe( 'MetricsSelectionPanel', () => {
 			expect( document.body ).toMatchSnapshot();
 		} );
 
-		it( 'should match snapshot with setupFlowRefresh enabled', async () => {
+		it( 'should render correctly with the `setupFlowRefresh` feature flag enabled', async () => {
 			const { waitForRegistry } = render( <MetricsSelectionPanel />, {
 				registry,
 				features: [ 'setupFlowRefresh' ],
@@ -188,20 +185,20 @@ describe( 'MetricsSelectionPanel', () => {
 			);
 		} );
 
-		it( 'should not display a settings link to edit personalized goals when `setupFlowRefresh` is enabled', async () => {
+		it( 'should not display a settings link to edit personalized goals for a view-only user when `setupFlowRefresh` is enabled', async () => {
 			const { container, waitForRegistry } = render(
 				<MetricsSelectionPanel />,
 				{
 					registry,
-					viewContext: VIEW_CONTEXT_MAIN_DASHBOARD,
+					viewContext: VIEW_CONTEXT_MAIN_DASHBOARD_VIEW_ONLY,
 					features: [ 'setupFlowRefresh' ],
 				}
 			);
 
 			await waitForRegistry();
 
 			expect( container ).not.toHaveTextContent(
-				'Edit your personalized goals or deactivate this widget in'
+				'Edit your personalized goals in'
 			);
 		} );
 	} );

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`// Jest Snapshot v1, https://goo.gl/fbAQLP`
`2`	`2`
`3`		-exports[`MetricsSelectionPanel Header should match snapshot with setupFlowRefresh enabled 1`] = `
	`3`	+exports[`MetricsSelectionPanel Header should render correctly 1`] = `
`4`	`4`	`<body`
`5`	`5`	`class="googlesitekit-side-sheet-scroll-lock"`
`6`	`6`	`>`
@@ -38,7 +38,7 @@ exports[`MetricsSelectionPanel Header should match snapshot with setupFlowRefres
`38`	`38`	`<p`
`39`	`39`	`class="googlesitekit-typography googlesitekit-typography--body googlesitekit-typography--medium"`
`40`	`40`	`>`
`41`		`- Edit your personalized goals in`
	`41`	`+ Edit your personalized goals or deactivate this widget in`
`42`	`42`	`<button`
`43`	`43`	`class="googlesitekit-cta-link googlesitekit-cta-link--secondary"`
`44`	`44`	`>`
@@ -301,7 +301,7 @@ exports[`MetricsSelectionPanel Header should match snapshot with setupFlowRefres
`301`	`301`	`</body>`
`302`	`302`	`;
`303`	`303`
`304`		-exports[`MetricsSelectionPanel Header should render correctly 1`] = `
	`304`	+exports[`MetricsSelectionPanel Header should render correctly with the \`setupFlowRefresh\` feature flag enabled 1`] = `
`305`	`305`	`<body`
`306`	`306`	`class="googlesitekit-side-sheet-scroll-lock"`
`307`	`307`	`>`
@@ -339,7 +339,7 @@ exports[`MetricsSelectionPanel Header should render correctly 1`] = `
`339`	`339`	`<p`
`340`	`340`	`class="googlesitekit-typography googlesitekit-typography--body googlesitekit-typography--medium"`
`341`	`341`	`>`
`342`		`- Edit your personalized goals or deactivate this widget in`
	`342`	`+ Edit your personalized goals in`
`343`	`343`	`<button`
`344`	`344`	`class="googlesitekit-cta-link googlesitekit-cta-link--secondary"`
`345`	`345`	`>`