Feature Description
In order to launch Setup Flow Refresh, we need to override the setupFlowRefresh feature flag status to true in the plugin. We can use the googlesitekit_is_feature_enabled filter to achieve this.
We're unable to progressively roll out the feature because we can't enable the flag via the service for new users who haven't yet signed in.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
- The
setupFlowRefresh feature flag is overridden to true in the plugin.
- The Setup Flow Refresh feature is enabled by default and continues to work as expected.
Implementation Brief
Test Coverage
- Add/extend PHPUnit coverage in
tests/phpunit/integration/PluginTest.php with respect to the above changes.
- Assert
apply_filters( 'googlesitekit_is_feature_enabled', false, 'setupFlowRefresh' ) returns true after plugin registration.
- Assert non-target flags still follow normal behavior.
- Fix any failing tests.
QA Brief
Changelog entry
Feature Description
In order to launch Setup Flow Refresh, we need to override the
setupFlowRefreshfeature flag status totruein the plugin. We can use thegooglesitekit_is_feature_enabledfilter to achieve this.We're unable to progressively roll out the feature because we can't enable the flag via the service for new users who haven't yet signed in.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
setupFlowRefreshfeature flag is overridden totruein the plugin.Implementation Brief
includes/Plugin.php:googlesitekit_is_feature_enabledfilter callback that forcessetupFlowRefreshtotrue.setupFlowRefreshonly; return the incoming$feature_enabledvalue unchanged for every other feature.Test Coverage
tests/phpunit/integration/PluginTest.phpwith respect to the above changes.apply_filters( 'googlesitekit_is_feature_enabled', false, 'setupFlowRefresh' )returnstrueafter plugin registration.QA Brief
Changelog entry