Skip to content

Commit 1be6895

Browse files
committed
dashboard/app: improve test names in TestUserAccessLevel
The test uses test names with spaces, testing package replaces spaces with _. As the result, it's impossible to search for failed tests, and they all look very similar. Replace space with _, so that it's possible to search for failed tests.
1 parent 66849ad commit 1be6895

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

dashboard/app/access_test.go

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -486,104 +486,104 @@ func TestUserAccessLevel(t *testing.T) {
486486
wantIsAuthorized bool
487487
}{
488488
{
489-
name: "wrong auth domain",
489+
name: "wrong_auth_domain",
490490
u: makeUser(BadAuthDomain),
491491
wantAccessLevel: AccessPublic,
492492
},
493493
{
494-
name: "regular not authenticated user",
494+
name: "regular_not_authenticated_user",
495495
u: makeUser(Regular),
496496
wantAccessLevel: AccessPublic,
497497
},
498498
{
499-
name: "regular not authenticated user wants to be an admin",
499+
name: "regular_not_authenticated_user_wants_to_be_an_admin",
500500
u: makeUser(Regular),
501501
enforcedAccessLevel: "admin",
502502
config: testConfig,
503503
wantAccessLevel: AccessPublic,
504504
},
505505
{
506-
name: "regular not authenticated user wants to be a user",
506+
name: "regular_not_authenticated_user_wants_to_be_a_user",
507507
u: makeUser(Regular),
508508
enforcedAccessLevel: "user",
509509
config: testConfig,
510510
wantAccessLevel: AccessPublic,
511511
},
512512
{
513-
name: "authenticated, not authorized user",
513+
name: "authenticated_not_authorized_user",
514514
u: makeUser(Authenticated),
515515
config: testConfig,
516516
wantAccessLevel: AccessPublic,
517517
},
518518
{
519-
name: "authenticated, not authorized user wants to be an admin",
519+
name: "authenticated_not_authorized_user_wants_to_be_an_admin",
520520
u: makeUser(Authenticated),
521521
enforcedAccessLevel: "admin",
522522
config: testConfig,
523523
wantAccessLevel: AccessPublic,
524524
},
525525
{
526-
name: "authenticated, not authorized user wants to be a user",
526+
name: "authenticated_not_authorized_user_wants_to_be_a_user",
527527
u: makeUser(Authenticated),
528528
enforcedAccessLevel: "user",
529529
config: testConfig,
530530
wantAccessLevel: AccessPublic,
531531
},
532532
{
533-
name: "authorized for AccessPublic user",
533+
name: "authorized_for_AccessPublic_user",
534534
u: makeUser(AuthorizedAccessPublic),
535535
config: testConfig,
536536
wantAccessLevel: AccessPublic,
537537
wantIsAuthorized: true,
538538
},
539539
{
540-
name: "authorized for AccessPublic user wants to be an admin",
540+
name: "authorized_for_AccessPublic_user_wants_to_be_an_admin",
541541
u: makeUser(AuthorizedAccessPublic),
542542
enforcedAccessLevel: "admin",
543543
config: testConfig,
544544
wantAccessLevel: AccessPublic,
545545
wantIsAuthorized: true,
546546
},
547547
{
548-
name: "authorized for AccessPublic user wants to be a user",
548+
name: "authorized_for_AccessPublic_user_wants_to_be_a_user",
549549
u: makeUser(AuthorizedAccessPublic),
550550
enforcedAccessLevel: "user",
551551
config: testConfig,
552552
wantAccessLevel: AccessPublic,
553553
wantIsAuthorized: true,
554554
},
555555
{
556-
name: "authorized for AccessUser user",
556+
name: "authorized_for_AccessUser_user",
557557
u: makeUser(AuthorizedUser),
558558
config: testConfig,
559559
wantAccessLevel: AccessUser,
560560
wantIsAuthorized: true,
561561
},
562562
{
563-
name: "authorized for AccessUser user wants to be an admin",
563+
name: "authorized_for_AccessUser_user_wants_to_be_an_admin",
564564
u: makeUser(AuthorizedUser),
565565
enforcedAccessLevel: "admin",
566566
config: testConfig,
567567
wantAccessLevel: AccessUser,
568568
wantIsAuthorized: true,
569569
},
570570
{
571-
name: "authorized admin wants AccessAdmin",
571+
name: "authorized_admin_wants_AccessAdmin",
572572
u: makeUser(AuthorizedAdmin),
573573
config: testConfig,
574574
wantAccessLevel: AccessAdmin,
575575
wantIsAuthorized: true,
576576
},
577577
{
578-
name: "authorized admin wants AccessPublic",
578+
name: "authorized_admin_wants_AccessPublic",
579579
u: makeUser(AuthorizedAdmin),
580580
enforcedAccessLevel: "public",
581581
config: testConfig,
582582
wantAccessLevel: AccessPublic,
583583
wantIsAuthorized: true,
584584
},
585585
{
586-
name: "authorized admin wants AccessUser",
586+
name: "authorized_admin_wants_AccessUser",
587587
u: makeUser(AuthorizedAdmin),
588588
enforcedAccessLevel: "user",
589589
config: testConfig,

0 commit comments

Comments
 (0)