Skip to content

Commit 1e8c392

Browse files
name2965a-nogikh
authored andcommitted
pkg/manager: add missing thead and tbody HTML tags
1 parent 2f1f7b8 commit 1e8c392

File tree

9 files changed

+46
-4
lines changed

9 files changed

+46
-4
lines changed

pkg/manager/html/corpus.html

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,13 @@
55

66
<table class="list_table">
77
<caption>Corpus{{if $.Call}} for {{$.Call}}{{end}}:</caption>
8+
<thead>
89
<tr>
910
<th>Coverage</th>
1011
<th>Program</th>
1112
</tr>
13+
</thead>
14+
<tbody>
1215
{{range $inp := $.Inputs}}
1316
<tr>
1417
<td>
@@ -20,4 +23,5 @@
2023
<td><a href="/input?sig={{$inp.Sig}}">{{$inp.Short}}</a></td>
2124
</tr>
2225
{{end}}
26+
</tbody>
2327
</table>

pkg/manager/html/crash.html

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,13 +10,16 @@
1010
{{end}}
1111

1212
<table class="list_table">
13+
<thead>
1314
<tr>
1415
<th>#</th>
1516
<th>Log</th>
1617
<th>Report</th>
1718
<th>Time</th>
1819
<th>Tag</th>
1920
</tr>
21+
</thead>
22+
<tbody>
2023
{{range $c := $.Crashes}}
2124
<tr>
2225
<td>{{$c.Index}}</td>
@@ -30,4 +33,5 @@
3033
<td class="tag {{if not $c.Active}}inactive{{end}}" title="{{$c.Tag}}">{{formatTagHash $c.Tag}}</td>
3134
</tr>
3235
{{end}}
36+
</tbody>
3337
</table>

pkg/manager/html/fallback_cover.html

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,20 @@
44
*/}}
55

66
<table class="list_table">
7+
<thead>
78
<tr>
89
<th>Call</th>
910
<th>Successful</th>
1011
<th>Errnos</th>
1112
</tr>
13+
</thead>
14+
<tbody>
1215
{{range $c := $.Calls}}
1316
<tr>
1417
<td>{{$c.Name}}</td>
1518
<td>{{if $c.Successful}}{{$c.Successful}}{{end}}</td>
1619
<td>{{range $e := $c.Errnos}}{{$e}}&nbsp;{{end}}</td>
1720
</tr>
1821
{{end}}
22+
</tbody>
1923
</table>

pkg/manager/html/job_list.html

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,20 @@
55

66
<table class="list_table">
77
<caption>{{.PageTitle}} ({{len .Jobs}}):</caption>
8+
<thead>
89
<tr>
910
<th>Program</th>
1011
<th>Calls</th>
1112
<th>Execs</th>
1213
</tr>
14+
</thead>
15+
<tbody>
1316
{{range $job := $.Jobs}}
1417
<tr>
1518
<td class="job_description"><a href='/jobs?id={{$job.ID}}'>{{$job.Short}}</a></td>
1619
<td class="job_description">{{$job.Calls}}</td>
1720
<td class="job_description">{{$job.Execs}}</td>
1821
</tr>
1922
{{end}}
23+
</tbody>
2024
</table>

pkg/manager/html/main.html

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
*/}}
55

66
<table class="list_table">
7+
<tbody>
78
{{range $s := $.Stats}}
89
<tr>
910
<td class="stat_name" title="{{$s.Hint}}">{{$s.Name}}</td>
@@ -16,11 +17,13 @@
1617
</td>
1718
</tr>
1819
{{end}}
20+
</tbody>
1921
</table>
2022

2123
{{if .Crashes}}
2224
<table class="list_table">
2325
<caption>Crashes:</caption>
26+
<thead>
2427
<tr>
2528
<th><a onclick="return sortTable(this, 'Description', textSort)" href="#">Description</a></th>
2629
<th><a onclick="return sortTable(this, 'Count', numSort)" href="#">Count</a></th>
@@ -29,6 +32,8 @@
2932
<th><a onclick="return sortTable(this, 'Report', textSort)" href="#">Report</a></th>
3033
<th><a onclick="return sortTable(this, 'Repro Attempt Count', numSort)" href="#">Repro Attempt Count</a></th>
3134
</tr>
35+
</thead>
36+
<tbody>
3237
{{range $c := $.Crashes}}
3338
<tr>
3439
<td class="title"><a href="/crash?id={{$c.ID}}">{{$c.Title}}</a></td>
@@ -46,17 +51,21 @@
4651
<td class="stat">{{if $c.ReproAttempts}}{{$c.ReproAttempts}}{{end}}</td>
4752
</tr>
4853
{{end}}
54+
</tbody>
4955
</table>
5056
{{end}}
5157

5258
{{define "diff_crashes"}}
5359
<table class="list_table">
5460
<caption>{{.Title}}:</caption>
61+
<thead>
5562
<tr>
5663
<th>Description</th>
5764
<th>Base</th>
5865
<th>Patched</th>
5966
</tr>
67+
</thead>
68+
<tbody>
6069
{{range $bug := .List}}
6170
<tr>
6271
<td class="title">{{$bug.Title}}</td>
@@ -90,6 +99,7 @@
9099
</td>
91100
</tr>
92101
{{end}}
102+
</tbody>
93103
</table>
94104
{{end}}
95105

pkg/manager/html/prio.html

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,18 @@
55

66
<table class="list_table">
77
<caption>Priorities for {{$.Call}}:</caption>
8+
<thead>
89
<tr>
910
<th><a onclick="return sortTable(this, 'Prio', floatSort)" href="#">Prio</a></th>
1011
<th><a onclick="return sortTable(this, 'Call', textSort)" href="#">Call</a></th>
1112
</tr>
13+
</thead>
14+
<tbody>
1215
{{range $p := $.Prios}}
1316
<tr>
1417
<td>{{printf "%5v" $p.Prio}}</td>
1518
<td><a href='/prio?call={{$p.Call}}'>{{$p.Call}}</a></td>
1619
</tr>
1720
{{end}}
21+
</tbody>
1822
</table>

pkg/manager/html/raw_cover.html

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,22 @@
55

66
<table class="list_table">
77
<caption>Raw cover</caption>
8+
<thead>
89
<tr>
910
<th>Line</th>
1011
<th>Links</th>
1112
</tr>
13+
</thead>
14+
<tbody>
1215
{{range $line := .Calls}}
1316
<tr>
1417
<td>{{$line.Call}}</td>
1518
<td>
16-
{{range $id := $line.UpdateIDs}}
17-
<a href="/rawcover?input={{$line.Sig}}&update_id={{$id}}">[{{$id}}]</a>
18-
{{end}}
19-
</td>
19+
{{range $id := $line.UpdateIDs}}
20+
<a href="/rawcover?input={{$line.Sig}}&update_id={{$id}}">[{{$id}}]</a>
21+
{{end}}
22+
</td>
2023
</tr>
2124
{{end}}
25+
</tbody>
2226
</table>

pkg/manager/html/syscalls.html

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
<table class="list_table">
77
<caption>Per-syscall coverage:</caption>
8+
<thead>
89
<tr>
910
<th><a onclick="return sortTable(this, 'Syscall', textSort)" href="#">Syscall</a></th>
1011
<th><a onclick="return sortTable(this, 'Inputs', numSort)" href="#" title="Number of inputs in the corpus added because of this syscall">Inputs</a></th>
@@ -14,6 +15,8 @@
1415
<th><a onclick="return sortTable(this, 'Comps overflows', numSort)" href="#" title="Number of times comparisons buffer has overflowed on this syscall">Comps overflows</a></th>
1516
<th>Prio</th>
1617
</tr>
18+
</thead>
19+
<tbody>
1720
{{range $c := $.Calls}}
1821
<tr>
1922
<td>{{$c.Name}}{{if $c.ID }} [{{$c.ID}}]{{end}}</td>
@@ -25,4 +28,5 @@
2528
<td><a href='/prio?call={{$c.Name}}'>prio</a></td>
2629
</tr>
2730
{{end}}
31+
</tbody>
2832
</table>

pkg/manager/html/vms.html

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,16 @@
55

66
<table class="list_table">
77
<caption>VM Info:</caption>
8+
<thead>
89
<tr>
910
<th><a onclick="return sortTable(this, 'Name', textSort)" href="#">Name</a></th>
1011
<th><a onclick="return sortTable(this, 'State', textSort)" href="#">State</a></th>
1112
<th><a onclick="return sortTable(this, 'Since', timeSort)" href="#">Since</a></th>
1213
<th><a onclick="return sortTable(this, 'Machine Info', timeSort)" href="#">Machine Info</a></th>
1314
<th><a onclick="return sortTable(this, 'Status', timeSort)" href="#">Status</a></th>
1415
</tr>
16+
</thead>
17+
<tbody>
1518
{{range $vm := $.VMs}}
1619
<tr>
1720
<td>{{$vm.Name}}</td>
@@ -21,4 +24,5 @@
2124
<td>{{optlink $vm.DetailedStatus "status"}}</td>
2225
</tr>
2326
{{end}}
27+
</tbody>
2428
</table>

0 commit comments

Comments
 (0)