all: remove loop variables scoping

Author: tarasmadan

dashboard/app/access_test.go

@@ -421,7 +421,6 @@ func TestAccess(t *testing.T) {
 				// In the short mode, only test that there's no public access to non-public URLs.
 				continue
 			}
-			ent := ent
 			t.Run(fmt.Sprintf("level%d_%d", requestLevel, i), func(t *testing.T) {
 				reply := checkPage(t, requestLevel, ent.level, ent.url)
 				checkReferences(t, ent.url, requestLevel, reply)

dashboard/app/email_test.go

@@ -473,7 +473,6 @@ func TestEmailDup(t *testing.T) {
 
 func TestEmailDup2(t *testing.T) {
 	for i := 0; i < 4; i++ {
-		i := i
 		t.Run(fmt.Sprint(i), func(t *testing.T) {
 			c := NewCtx(t)
 			defer c.Close()

dashboard/app/jobs.go

@@ -1855,7 +1855,6 @@ func (j *bugJob) loadBuild(c context.Context) error {
 func fullBackportInfo(c context.Context, list []*backportInfo) error {
 	crashLoader := &dependencyLoader[Crash]{}
 	for _, info := range list {
-		info := info
 		if info.job.CrashID == 0 {
 			continue
 		}
@@ -1869,7 +1868,6 @@ func fullBackportInfo(c context.Context, list []*backportInfo) error {
 	}
 	buildLoader := &dependencyLoader[Build]{}
 	for _, info := range list {
-		info := info
 		if info.crash == nil {
 			continue
 		}

dashboard/app/reporting_test.go

@@ -1213,7 +1213,6 @@ func TestObsoletePeriod(t *testing.T) {
 	}
 
 	for _, test := range tests {
-		test := test
 		t.Run(test.name, func(t *testing.T) {
 			ret := test.bug.obsoletePeriod(c)
 			assert.Equal(t, test.period, ret)

dashboard/app/stats.go

@@ -84,7 +84,6 @@ func allBugInputs(c context.Context, ns string) ([]*bugInput, error) {
 	}
 	buildLoader := &dependencyLoader[Build]{}
 	for _, input := range inputs {
-		input := input
 		if input.reportedCrash == nil {
 			continue
 		}

pkg/bisect/bisect_test.go

@@ -732,7 +732,6 @@ func TestBisectionResults(t *testing.T) {
 	repoCache := make(chan string, len(bisectionTests))
 	t.Run("group", func(tt *testing.T) {
 		for _, test := range bisectionTests {
-			test := test
 			tt.Run(test.name, func(t *testing.T) {
 				t.Parallel()
 				checkTest(t, test)
@@ -889,7 +888,6 @@ func TestBisectVerdict(t *testing.T) {
 	}
 
 	for _, test := range tests {
-		test := test
 		t.Run(test.name, func(t *testing.T) {
 			sum := test.good + test.bad + test.infra + test.skip
 			assert.Equal(t, test.total, sum)
@@ -1008,7 +1006,6 @@ func TestMostFrequentReport(t *testing.T) {
 		},
 	}
 	for _, test := range tests {
-		test := test
 		t.Run(test.name, func(t *testing.T) {
 			rep, types, other := mostFrequentReports(test.reports)
 			assert.ElementsMatch(t, types, test.types)
@@ -1066,7 +1063,6 @@ func TestPickReleaseTags(t *testing.T) {
 		},
 	}
 	for _, test := range tests {
-		test := test
 		t.Run(test.name, func(t *testing.T) {
 			ret := pickReleaseTags(append([]string{}, test.tags...))
 			assert.Equal(t, test.ret, ret)

pkg/bisect/minimize/slice_test.go

@@ -112,7 +112,6 @@ func TestBisectRandomSlice(t *testing.T) {
 
 func BenchmarkSplits(b *testing.B) {
 	for _, guilty := range []int{1, 2, 3, 4} {
-		guilty := guilty
 		b.Run(fmt.Sprintf("%d_guilty", guilty), func(b *testing.B) {
 			var sum int
 			for i := 0; i < b.N; i++ {

pkg/build/build_test.go

@@ -17,7 +17,6 @@ import (
 func TestCompilerIdentity(t *testing.T) {
 	t.Parallel()
 	for _, compiler := range []string{"gcc", "clang", "bazel"} {
-		compiler := compiler
 		t.Run(compiler, func(t *testing.T) {
 			t.Parallel()
 			if _, err := exec.LookPath(compiler); err != nil {
@@ -42,7 +41,6 @@ func TestCompilerIdentity(t *testing.T) {
 
 func TestExtractCauseInner(t *testing.T) {
 	for i, test := range rootCauseTests {
-		test := test
 		t.Run(fmt.Sprint(i), func(t *testing.T) {
 			reason, file := extractCauseInner([]byte(test.e), test.src)
 			if test.reason != string(reason) {

pkg/compiler/compiler_test.go

@@ -23,7 +23,6 @@ var flagUpdate = flag.Bool("update", false, "reformat all.txt")
 
 func TestCompileAll(t *testing.T) {
 	for os, arches := range targets.List {
-		os, arches := os, arches
 		t.Run(os, func(t *testing.T) {
 			t.Parallel()
 			eh := func(pos ast.Pos, msg string) {
@@ -35,7 +34,6 @@ func TestCompileAll(t *testing.T) {
 				t.Fatalf("parsing failed")
 			}
 			for arch, target := range arches {
-				arch, target := arch, target
 				t.Run(arch, func(t *testing.T) {
 					t.Parallel()
 					errors := new(bytes.Buffer)
@@ -68,7 +66,6 @@ func TestData(t *testing.T) {
 	// Because of this we have one file per phase.
 	for _, name := range []string{"errors.txt", "errors2.txt", "errors3.txt", "warnings.txt", "all.txt"} {
 		for _, arch := range []string{targets.TestArch32, targets.TestArch64} {
-			name, arch := name, arch
 			t.Run(fmt.Sprintf("%v/%v", name, arch), func(t *testing.T) {
 				t.Parallel()
 				target := targets.List[targets.TestOS][arch]

pkg/cover/backend/dwarf.go

@@ -161,8 +161,6 @@ func makeDWARFUnsafe(params *dwarfParams) (*Impl, error) {
 	}
 	binC := make(chan binResult, len(modules))
 	for _, module := range modules {
-		// check https://go.dev/blog/loopvar-preview for loopvar bug
-		module := module
 		go func() {
 			info := &symbolInfo{
 				tracePC:     make(map[uint64]bool),