syz-cluster: perform a patched kernel boot test

Report the findings only for the boot test of the patched kernel.

Author: a-nogikh

syz-cluster/pkg/workflow/template.yaml

@@ -120,13 +120,37 @@ spec:
                   value: "{{=jsonpath(steps['base-build'].outputs.parameters.result, '$.build_id')}}"
                 - name: test-name
                   value: "Boot test: Base"
+          - name: boot-test-patched
+            templateRef:
+              name: boot-step-template
+              template: boot-step
+            arguments:
+              artifacts:
+                - name: kernel
+                  from: "{{steps.patched-build.outputs.artifacts.kernel}}"
+              parameters:
+                - name: config
+                  value: "{{=jsonpath(inputs.parameters.element, '$.config')}}"
+                - name: patched-build-id
+                  value: "{{=jsonpath(steps['patched-build'].outputs.parameters.result, '$.build_id')}}"
+                - name: report-findings
+                  value: "true"
+                - name: test-name
+                  value: "Boot test: Patched"
         - - name: break-if-base-boot-failed
             template: exit-workflow
             arguments:
               parameters:
                 - name: code
                   value: 0
             when: "{{=jsonpath(steps['boot-test-base'].outputs.parameters.result, '$.success') == false}}"
+        - - name: break-if-patched-boot-failed
+            template: exit-workflow
+            arguments:
+              parameters:
+                - name: code
+                  value: 0
+            when: "{{=jsonpath(steps['boot-test-patched'].outputs.parameters.result, '$.success') == false}}"
     - name: extract-request
       inputs:
         parameters:

syz-cluster/workflow/boot-step/main.go

@@ -24,6 +24,7 @@ var (
 	flagBaseBuild    = flag.String("base_build", "", "base build ID")
 	flagPatchedBuild = flag.String("patched_build", "", "patched build ID")
 	flagOutput       = flag.String("output", "", "where to store the result")
+	flagFindings     = flag.Bool("findings", false, "report failur as findings")
 )
 
 func main() {
@@ -79,9 +80,13 @@ func runTest(ctx context.Context, client *api.Client) (bool, error) {
 	rep, err := instance.RunSmokeTest(cfg)
 	if err != nil {
 		return false, err
+	} else if rep == nil {
+		return true, nil
 	}
-	if rep != nil {
-		log.Printf("uploading the finding %q", rep.Title)
+
+	log.Printf("found: %q", rep.Title)
+	if *flagFindings {
+		log.Printf("reporting the finding")
 		findingErr := client.UploadFinding(ctx, &api.Finding{
 			SessionID: *flagSession,
 			TestName:  *flagTestName,
@@ -92,7 +97,6 @@ func runTest(ctx context.Context, client *api.Client) (bool, error) {
 		if findingErr != nil {
 			return false, fmt.Errorf("failed to report the finding: %w", findingErr)
 		}
-		return false, nil
 	}
-	return true, nil
+	return false, nil
 }

syz-cluster/workflow/boot-step/workflow-template.yaml

@@ -18,6 +18,8 @@ spec:
             value: ""
           - name: test-name
             value: ""
+          - name: report-findings
+            value: "false"
         artifacts:
           - name: kernel
             path: /kernel
@@ -31,8 +33,16 @@ spec:
           "--session", "{{workflow.parameters.session-id}}",
           "--test_name", "{{inputs.parameters.test-name}}",
           "--base_build", "{{inputs.parameters.base-build-id}}",
-          "--patched_build", "{{inputs.parameters.patched-build-id}}"
+          "--patched_build", "{{inputs.parameters.patched-build-id}}",
+          "-findings={{inputs.parameters.report-findings}}"
           ]
+        resources:
+          requests:
+            cpu: 6
+            memory: 12G
+          limits:
+            cpu: 8
+            memory: 24G
         volumeMounts:
         - name: workdir
           mountPath: /workdir