pkg/report: factor out type definitions

Side fix - prefix the rust reports.

Author: tarasmadan

pkg/report/darwin.go

@@ -5,8 +5,6 @@ package report
 
 import (
 	"regexp"
-
-	"github.com/google/syzkaller/pkg/report/crash"
 )
 
 func ctorDarwin(cfg *config) (reporterImpl, []string, error) {
@@ -45,7 +43,6 @@ var darwinOopses = append([]*oops{
 			},
 		},
 		[]*regexp.Regexp{},
-		crash.UnknownType,
 	},
 	{
 		[]byte("Debugger: Unexpected kernel trap number:"),
@@ -56,7 +53,6 @@ var darwinOopses = append([]*oops{
 			},
 		},
 		[]*regexp.Regexp{},
-		crash.UnknownType,
 	},
 	&groupGoRuntimeErrors,
 }, commonOopses...)

pkg/report/freebsd.go

@@ -5,8 +5,6 @@ package report
 
 import (
 	"regexp"
-
-	"github.com/google/syzkaller/pkg/report/crash"
 )
 
 type freebsd struct {
@@ -57,7 +55,6 @@ var freebsdOopses = append([]*oops{
 			},
 		},
 		[]*regexp.Regexp{},
-		crash.UnknownType,
 	},
 	{
 		[]byte("panic:"),
@@ -105,7 +102,6 @@ var freebsdOopses = append([]*oops{
 			},
 		},
 		[]*regexp.Regexp{},
-		crash.UnknownType,
 	},
 	&groupGoRuntimeErrors,
 }, commonOopses...)

pkg/report/fuchsia.go

@@ -11,7 +11,6 @@ import (
 	"strconv"
 	"strings"
 
-	"github.com/google/syzkaller/pkg/report/crash"
 	"github.com/google/syzkaller/pkg/symbolizer"
 	"github.com/ianlancetaylor/demangle"
 )
@@ -324,7 +323,6 @@ var zirconOopses = []*oops{
 			},
 		},
 		[]*regexp.Regexp{},
-		crash.UnknownType,
 	},
 	{
 		[]byte("recursion in interrupt handler"),
@@ -345,7 +343,6 @@ var zirconOopses = []*oops{
 			},
 		},
 		[]*regexp.Regexp{},
-		crash.UnknownType,
 	},
 	// We should detect just "stopping other cpus" as some kernel crash rather then as "lost connection",
 	// but if we add oops for "stopping other cpus", then it will interfere with other formats,
@@ -360,11 +357,9 @@ var zirconOopses = []*oops{
 				title:        compile("welcome to Zircon"),
 				fmt:          "unexpected kernel reboot",
 				noStackTrace: true,
-				reportType:   crash.UnexpectedReboot,
 			},
 		},
 		[]*regexp.Regexp{},
-		crash.UnknownType,
 	},
 	{
 		[]byte("KVM internal error"),
@@ -376,7 +371,6 @@ var zirconOopses = []*oops{
 			},
 		},
 		[]*regexp.Regexp{},
-		crash.UnknownType,
 	},
 	{
 		[]byte("<== fatal exception"),
@@ -391,7 +385,6 @@ var zirconOopses = []*oops{
 		[]*regexp.Regexp{
 			compile("<== fatal exception: process .+?syz.+?\\["),
 		},
-		crash.UnknownType,
 	},
 }
 
@@ -412,7 +405,6 @@ var starnixOopses = []*oops{
 			},
 		},
 		[]*regexp.Regexp{},
-		crash.UnknownType,
 	},
 }
 

pkg/report/gvisor.go

@@ -6,8 +6,6 @@ package report
 import (
 	"bytes"
 	"regexp"
-
-	"github.com/google/syzkaller/pkg/report/crash"
 )
 
 type gvisor struct {
@@ -106,7 +104,6 @@ var gvisorOopses = append([]*oops{
 			},
 		},
 		[]*regexp.Regexp{},
-		crash.UnknownType,
 	},
 	{
 		[]byte("SIGSEGV:"),
@@ -118,7 +115,6 @@ var gvisorOopses = append([]*oops{
 			},
 		},
 		[]*regexp.Regexp{},
-		crash.UnknownType,
 	},
 	{
 		[]byte("SIGBUS:"),
@@ -130,7 +126,6 @@ var gvisorOopses = append([]*oops{
 			},
 		},
 		[]*regexp.Regexp{},
-		crash.UnknownType,
 	},
 	{
 		[]byte("FATAL ERROR:"),
@@ -142,7 +137,6 @@ var gvisorOopses = append([]*oops{
 			},
 		},
 		[]*regexp.Regexp{},
-		crash.UnknownType,
 	},
 	{
 		[]byte("WARNING: DATA RACE"),
@@ -155,7 +149,6 @@ var gvisorOopses = append([]*oops{
 			},
 		},
 		[]*regexp.Regexp{},
-		crash.UnknownType,
 	},
 	{
 		[]byte("Invalid request partialResult"),
@@ -168,7 +161,6 @@ var gvisorOopses = append([]*oops{
 			},
 		},
 		[]*regexp.Regexp{},
-		crash.UnknownType,
 	},
 	{
 		[]byte("fatal error:"),
@@ -180,6 +172,5 @@ var gvisorOopses = append([]*oops{
 			},
 		},
 		[]*regexp.Regexp{},
-		crash.UnknownType,
 	},
 }, commonOopses...)