vm/qemu: additional check for crashes only in Diagnose

vm/qemu: additional check for crashes only in Diagnose

vm/qemu: additional check for crashes only in Diagnose

Author: georghegel

vm/qemu/qemu.go

@@ -23,6 +23,7 @@ import (
 	"github.com/google/syzkaller/pkg/log"
 	"github.com/google/syzkaller/pkg/osutil"
 	"github.com/google/syzkaller/pkg/report"
+	"github.com/google/syzkaller/pkg/report/crash"
 	"github.com/google/syzkaller/sys/targets"
 	"github.com/google/syzkaller/vm/vmimpl"
 )
@@ -734,8 +735,11 @@ func (inst *instance) Diagnose(rep *report.Report) ([]byte, bool) {
 			return output, wait
 		}
 	}
-	// TODO: we don't need registers on all reports. Probably only relevant for "crashes"
-	// (NULL derefs, paging faults, etc), but is not useful for WARNING/BUG/HANG (?).
+
+	if !needsRegisterInfo(rep) {
+		return nil, false
+	}
+
 	ret := []byte(fmt.Sprintf("%s Registers:\n", time.Now().Format("15:04:05 ")))
 	for cpu := 0; cpu < inst.cfg.CPU; cpu++ {
 		regs, err := inst.hmp("info registers", cpu)
@@ -750,6 +754,54 @@ func (inst *instance) Diagnose(rep *report.Report) ([]byte, bool) {
 	return ret, false
 }
 
+func needsRegisterInfo(rep *report.Report) bool {
+	switch rep.Type {
+	case crash.NullPtrDerefBUG,
+		crash.KASANNullPtrDerefRead,
+		crash.KASANNullPtrDerefWrite,
+		crash.KFENCEMemoryCorruption:
+		return true
+	case crash.KASANRead,
+		crash.KASANWrite,
+		crash.KASANUseAfterFreeRead,
+		crash.KASANUseAfterFreeWrite,
+		crash.KFENCERead,
+		crash.KFENCEWrite,
+		crash.KFENCEUseAfterFreeRead,
+		crash.KFENCEUseAfterFreeWrite:
+		return true
+	case crash.KASANInvalidFree,
+		crash.KFENCEInvalidFree:
+		return true
+	case crash.MemorySafetyBUG,
+		crash.MemorySafetyUBSAN:
+		return true
+	case crash.Bug:
+		return true
+	case crash.Warning,
+		crash.AtomicSleep,
+		crash.Hang,
+		crash.DoS,
+		crash.KCSANAssert,
+		crash.KCSANDataRace,
+		crash.KCSANUnknown,
+		crash.KMSANInfoLeak,
+		crash.KMSANUninitValue,
+		crash.KMSANUnknown,
+		crash.KMSANUseAfterFreeRead,
+		crash.LockdepBug,
+		crash.MemoryLeak,
+		crash.RefcountWARNING,
+		crash.UBSAN,
+		crash.LostConnection,
+		crash.SyzFailure,
+		crash.UnexpectedReboot:
+		return false
+	default:
+		return true
+	}
+}
+
 func (inst *instance) ssh(args ...string) ([]byte, error) {
 	return osutil.RunCmd(time.Minute*inst.timeouts.Scale, "", "ssh", inst.sshArgs(args...)...)
 }