Skip to content

Commit d461181

Browse files
pimyn-girgispimyn-girgis
committed
pkg/report: ignore the fast_dput/dput frames
fast_dput and dput are too generic. This causes several different bugs to be merged into one. See: https://syzkaller.appspot.com/bug?extid=b74150fd2ef40e716ca2 Ingore the fast_dput/dput frames when selecting the bug title.
1 parent 3887d60 commit d461181

File tree

3 files changed

+123
-0
lines changed

3 files changed

+123
-0
lines changed

‎pkg/report/linux.go‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1398,6 +1398,8 @@ var linuxStackParams = &stackParams{
13981398
"__timer_delete_sync",
13991399
"sk_stop_timer_sync",
14001400
"__mod_timer",
1401+
"fast_dput",
1402+
"dput",
14011403
},
14021404
corruptedLines: []*regexp.Regexp{
14031405
// Fault injection stacks are frequently intermixed with crash reports.

‎pkg/report/testdata/linux/report/756‎

Lines changed: 76 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,76 @@
1+
TITLE: WARNING in ovl_stack_put
2+
TYPE: WARNING
3+
4+
[ 195.358969][ T5830] ------------[ cut here ]------------
5+
[ 195.364985][ T5830] WARNING: fs/dcache.c:829 at fast_dput+0x334/0x430, CPU#1: syz-executor/5830
6+
[ 195.373920][ T5830] Modules linked in:
7+
[ 195.378541][ T5830] CPU: 1 UID: 0 PID: 5830 Comm: syz-executor Not tainted syzkaller #0 PREEMPT(full)
8+
[ 195.388052][ T5830] Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/25/2025
9+
[ 195.388344][ T5935] usb 4-1: Using ep0 maxpacket: 16
10+
[ 195.398271][ T5830] RIP: 0010:fast_dput+0x334/0x430
11+
[ 195.408590][ T5830] Code: e3 81 ff 48 b8 00 00 00 00 00 fc ff df 41 0f b6 44 05 00 84 c0 0f 85 e2 00 00 00 41 80 0e 40 e9 fd fe ff ff e8 4d e3 81 ff 90 <0f> 0b 90 e9 ef fe ff ff 44 89 e6 81 e6 00 00 04 00 31 ff e8 74 e7
12+
[ 195.410107][ T5825] usb 1-1: config index 0 descriptor too short (expected 215, got 45)
13+
[ 195.428283][ T5830] RSP: 0018:ffffc900040af8e8 EFLAGS: 00010293
14+
[ 195.428311][ T5830] RAX: ffffffff82400fe3 RBX: ffff888059c7a0b8 RCX: ffff888028138000
15+
[ 195.428326][ T5830] RDX: 0000000000000000 RSI: 00000000ffffff80 RDI: 0000000000000001
16+
[ 195.428337][ T5830] RBP: 00000000ffffff80 R08: 0000000000000003 R09: 0000000000000004
17+
[ 195.428349][ T5830] R10: dffffc0000000000 R11: fffff52000815f0c R12: dffffc0000000000
18+
[ 195.428362][ T5830] R13: 1ffff1100b38f41f R14: ffff888059c7a000 R15: ffff888059c7a0f8
19+
[ 195.428376][ T5830] FS: 000055557e3d5500(0000) GS:ffff888125b03000(0000) knlGS:0000000000000000
20+
[ 195.428393][ T5830] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
21+
[ 195.428407][ T5830] CR2: 00007ffd130c7ba8 CR3: 000000005dd7a000 CR4: 00000000003526f0
22+
[ 195.428425][ T5830] Call Trace:
23+
[ 195.428434][ T5830] <TASK>
24+
[ 195.428442][ T5830] ? dput+0x37/0x1a0
25+
[ 195.428467][ T5830] dput+0xe8/0x1a0
26+
[ 195.446260][ T5825] usb 1-1: New USB device found, idVendor=0424, idProduct=7850, bcdDevice= 0.00
27+
[ 195.450810][ T5830] ovl_stack_put+0x6a/0xa0
28+
[ 195.450848][ T5830] ovl_destroy_inode+0xaa/0x150
29+
[ 195.450870][ T5830] evict+0x8aa/0xae0
30+
[ 195.450901][ T5830] ? __pfx_evict+0x10/0x10
31+
[ 195.450922][ T5830] ? _raw_spin_unlock+0x28/0x50
32+
[ 195.450942][ T5830] ? iput+0xcc6/0x1030
33+
[ 195.450970][ T5830] __dentry_kill+0x209/0x660
34+
[ 195.450996][ T5830] ? shrink_kill+0x8d/0x2c0
35+
[ 195.451013][ T5830] shrink_kill+0xa9/0x2c0
36+
[ 195.451032][ T5830] shrink_dentry_list+0x2e0/0x5e0
37+
[ 195.451054][ T5830] ? __pfx_select_collect_umount+0x10/0x10
38+
[ 195.451077][ T5830] shrink_dcache_tree+0xca/0x2e0
39+
[ 195.459502][ T5825] usb 1-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
40+
[ 195.467176][ T5830] ? __pfx_select_collect_umount+0x10/0x10
41+
[ 195.467220][ T5830] ? __pfx_shrink_dcache_tree+0x10/0x10
42+
[ 195.480866][ T5825] usb 1-1: Product: syz
43+
[ 195.483638][ T5830] do_one_tree+0x28/0xe0
44+
[ 195.495414][ T5825] usb 1-1: Manufacturer: syz
45+
[ 195.498996][ T5830] shrink_dcache_for_umount+0xa0/0x170
46+
[ 195.499032][ T5830] generic_shutdown_super+0x67/0x2c0
47+
[ 195.499057][ T5830] kill_anon_super+0x3b/0x70
48+
[ 195.499080][ T5830] deactivate_locked_super+0xbc/0x130
49+
[ 195.508417][ T5935] usb 4-1: unable to get BOS descriptor or descriptor too short
50+
[ 195.510405][ T5830] cleanup_mnt+0x425/0x4c0
51+
[ 195.513631][ T5825] usb 1-1: SerialNumber: syz
52+
[ 195.517316][ T5830] ? lockdep_hardirqs_on+0x98/0x140
53+
[ 195.517349][ T5830] task_work_run+0x1d4/0x260
54+
[ 195.517381][ T5830] ? __pfx_task_work_run+0x10/0x10
55+
[ 195.517406][ T5830] ? exit_to_user_mode_loop+0x55/0x4f0
56+
[ 195.517434][ T5830] exit_to_user_mode_loop+0xff/0x4f0
57+
[ 195.523031][ T5935] usb 4-1: config 127 has an invalid descriptor of length 0, skipping remainder of the config
58+
[ 195.530247][ T5830] ? rcu_is_watching+0x15/0xb0
59+
[ 195.534784][ T5935] usb 4-1: config 127 has 0 interfaces, different from the descriptor's value: 1
60+
[ 195.539532][ T5830] do_syscall_64+0x2e3/0xf80
61+
[ 195.539574][ T5830] ? entry_SYSCALL_64_after_hwframe+0x77/0x7f
62+
[ 195.681013][ T5935] usb 4-1: New USB device found, idVendor=04b8, idProduct=0202, bcdDevice=3e.b8
63+
[ 195.683279][ T5830] ? clear_bhb_loop+0x60/0xb0
64+
[ 195.683313][ T5830] entry_SYSCALL_64_after_hwframe+0x77/0x7f
65+
[ 195.694429][ T5935] usb 4-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3
66+
[ 195.698420][ T5830] RIP: 0033:0x7fa45b190a77
67+
[ 195.698446][ T5830] Code: a8 ff ff ff f7 d8 64 89 01 48 83 c8 ff c3 0f 1f 44 00 00 31 f6 e9 09 00 00 00 66 0f 1f 84 00 00 00 00 00 b8 a6 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 01 c3 48 c7 c2 a8 ff ff ff f7 d8 64 89 02 b8
68+
[ 195.698462][ T5830] RSP: 002b:00007ffd130c8358 EFLAGS: 00000246 ORIG_RAX: 00000000000000a6
69+
[ 195.698484][ T5830] RAX: 0000000000000000 RBX: 00007fa45b213d7d RCX: 00007fa45b190a77
70+
[ 195.698498][ T5830] RDX: 0000000000000000 RSI: 0000000000000009 RDI: 00007ffd130c8410
71+
[ 195.708629][ T5935] usb 4-1: Product: syz
72+
[ 195.712202][ T5830] RBP: 00007ffd130c8410 R08: 0000000000000000 R09: 0000000000000000
73+
[ 195.712219][ T5830] R10: 00000000ffffffff R11: 0000000000000246 R12: 00007ffd130c94a0
74+
[ 195.712233][ T5830] R13: 00007fa45b213d7d R14: 000000000002fadc R15: 00007ffd130c94e0
75+
[ 195.738345][ T5935] usb 4-1: Manufacturer: syz
76+
[ 195.746308][ T5830] </TASK>

‎pkg/report/testdata/linux/report/757‎

Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
TITLE: WARNING in __fput
2+
TYPE: WARNING
3+
FRAME: __fput
4+
EXECUTOR: proc=0, id=17
5+
6+
[ 113.525303][ T6007] ------------[ cut here ]------------
7+
[ 113.532065][ T6007] WARNING: fs/dcache.c:829 at fast_dput+0x334/0x430, CPU#0: syz.0.17/6007
8+
[ 113.543506][ T6007] Modules linked in:
9+
[ 113.548207][ T6007] CPU: 0 UID: 0 PID: 6007 Comm: syz.0.17 Not tainted syzkaller #0 PREEMPT(full)
10+
[ 113.561542][ T6007] Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/25/2025
11+
[ 113.573975][ T6007] RIP: 0010:fast_dput+0x334/0x430
12+
[ 113.579615][ T6007] Code: e3 81 ff 48 b8 00 00 00 00 00 fc ff df 41 0f b6 44 05 00 84 c0 0f 85 e2 00 00 00 41 80 0e 40 e9 fd fe ff ff e8 4d e3 81 ff 90 <0f> 0b 90 e9 ef fe ff ff 44 89 e6 81 e6 00 00 04 00 31 ff e8 74 e7
13+
[ 113.601996][ T6007] RSP: 0018:ffffc90003defcd8 EFLAGS: 00010293
14+
[ 113.610633][ T6007] RAX: ffffffff823fcfe3 RBX: ffff888072eb9838 RCX: ffff8880781cdb80
15+
[ 113.619412][ T6007] RDX: 0000000000000000 RSI: 00000000ffffff80 RDI: 0000000000000001
16+
[ 113.628829][ T6007] RBP: 00000000ffffff80 R08: 0000000000000003 R09: 0000000000000004
17+
[ 113.638132][ T6007] R10: dffffc0000000000 R11: fffff520007bdf8c R12: dffffc0000000000
18+
[ 113.647473][ T6007] R13: 1ffff1100e5d730f R14: ffff888072eb9780 R15: ffff888072eb9878
19+
[ 113.656432][ T6007] FS: 000055556ac01500(0000) GS:ffff888125e4f000(0000) knlGS:0000000000000000
20+
[ 113.665903][ T6007] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
21+
[ 113.673094][ T6007] CR2: 0000001b2f963fff CR3: 00000000762f6000 CR4: 00000000003526f0
22+
[ 113.681856][ T6007] Call Trace:
23+
[ 113.685559][ T6007] <TASK>
24+
[ 113.688707][ T6007] ? dput+0x37/0x1a0
25+
[ 113.693542][ T6007] dput+0xe8/0x1a0
26+
[ 113.698424][ T6007] __fput+0x68e/0xa70
27+
[ 113.702830][ T6007] task_work_run+0x1d4/0x260
28+
[ 113.709002][ T6007] ? __pfx_task_work_run+0x10/0x10
29+
[ 113.715078][ T6007] ? __se_sys_close_range+0x4ed/0x650
30+
[ 113.721633][ T6007] ? exit_to_user_mode_loop+0x55/0x4f0
31+
[ 113.728494][ T6007] exit_to_user_mode_loop+0xff/0x4f0
32+
[ 113.736166][ T6007] ? rcu_is_watching+0x15/0xb0
33+
[ 113.743330][ T6007] do_syscall_64+0x2e3/0xf80
34+
[ 113.748224][ T6007] ? entry_SYSCALL_64_after_hwframe+0x77/0x7f
35+
[ 113.754527][ T6007] ? clear_bhb_loop+0x60/0xb0
36+
[ 113.759668][ T6007] entry_SYSCALL_64_after_hwframe+0x77/0x7f
37+
[ 113.766306][ T6007] RIP: 0033:0x7fe73eb8f749
38+
[ 113.771627][ T6007] Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
39+
[ 113.794270][ T6007] RSP: 002b:00007ffde5b9bed8 EFLAGS: 00000246 ORIG_RAX: 00000000000001b4
40+
[ 113.803489][ T6007] RAX: 0000000000000000 RBX: 000000000001bb15 RCX: 00007fe73eb8f749
41+
[ 113.814324][ T6007] RDX: 0000000000000000 RSI: 000000000000001e RDI: 0000000000000003
42+
[ 113.824073][ T6007] RBP: 0000000000000000 R08: 0000000000000001 R09: 00000002e5b9c1cf
43+
[ 113.834376][ T6007] R10: 0000001b2ed20000 R11: 0000000000000246 R12: 00007fe73ede5fac
44+
[ 113.844782][ T6007] R13: 00007fe73ede5fa0 R14: ffffffffffffffff R15: 0000000000000004
45+
[ 113.855481][ T6007] </TASK>

0 commit comments

Comments
 (0)