pkg/fuzzer: remove an unnecessary clone

a-nogikh · a-nogikh · commit e347022420b4 · 2025-04-02T14:41:11.000Z
The Clone() we do at the beginning of the handleCall() function is unnecessary and may even confuse the people wo read and modify the code (see #5878). For all the jobs we start below, we anyway do another Clone() of the program. The corpus also does not assume that the programs in it will be modified elsewhere.
diff --git a/pkg/fuzzer/job.go b/pkg/fuzzer/job.go
@@ -166,7 +166,7 @@ func (job *triageJob) handleCall(call int, info *triageCall) {
 		return
 	}
 
-	p := job.p.Clone()
+	p := job.p
 	if job.flags&ProgMinimized == 0 {
 		p, call = job.minimize(call, info)
 		if p == nil {

Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,7 @@ func (job triageJob) handleCall(call int, info triageCall) {`
`166`	`166`	`return`
`167`	`167`	`}`
`168`	`168`
`169`		`- p := job.p.Clone()`
	`169`	`+ p := job.p`
`170`	`170`	`if job.flags&ProgMinimized == 0 {`
`171`	`171`	`p, call = job.minimize(call, info)`
`172`	`172`	`if p == nil {`