syz-cluster: fix db-mgmt job problems

a-nogikh · a-nogikh · commit ed351ea732d8 · 2025-05-23T16:30:38.000Z
Don't restart the job if it returned a non-zero exit code.
Don't treat the ErrNoChange error as a failure.
diff --git a/syz-cluster/db-mgmt/migrate-job.yaml b/syz-cluster/db-mgmt/migrate-job.yaml
@@ -7,6 +7,7 @@ metadata:
   generateName: db-migrate-job-
 spec:
   ttlSecondsAfterFinished: 86400
+  backoffLimit: 0
   template:
     spec:
       serviceAccountName: gke-db-admin-ksa
diff --git a/syz-cluster/pkg/db/spanner.go b/syz-cluster/pkg/db/spanner.go
@@ -109,7 +109,12 @@ func RunMigrations(uri string) error {
 	if err != nil {
 		return err
 	}
-	return m.Up()
+	err = m.Up()
+	if err == migrate.ErrNoChange {
+		// Not really an error.
+		return nil
+	}
+	return err
 }
 
 func getMigrateInstance(uri string) (*migrate.Migrate, error) {

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,12 @@ func RunMigrations(uri string) error {`
`109`	`109`	`if err != nil {`
`110`	`110`	`return err`
`111`	`111`	`}`
`112`		`- return m.Up()`
	`112`	`+ err = m.Up()`
	`113`	`+ if err == migrate.ErrNoChange {`
	`114`	`+ // Not really an error.`
	`115`	`+ return nil`
	`116`	`+ }`
	`117`	`+ return err`
`113`	`118`	`}`
`114`	`119`
`115`	`120`	`func getMigrateInstance(uri string) (*migrate.Migrate, error) {`